Update to use LibGit2Sharp v0.24 #1248
Conversation
|
In this build, I've changed from using LibGit2Sharp 0.22 to 0.23.1 and from LibGit2Sharp.NativeBinaries.1.0.129 to 1.0.164.
I'm going to ask the user if this fixes the issue they were seeing. |
|
👍 Let me know if it doesn't work and we can debug further. |
|
Hi everybody.
First I'd like to thanks to all support team. You're all awesome.
Unfortunately I have no more time to waiting for a solution. I reinstalled
VS2017 completely. All new and now, of course, GitHub works fine.
Thanks a lot indeed.
BR
2017-10-05 8:48 GMT-03:00 Jamie Cansdale <notifications@github.com>:
… In this build, I've changed from using LibGit2Sharp 0.22 to 0.23.1 and
from LibGit2Sharp.NativeBinaries.1.0.129 to 1.0.164.
GitHub.VisualStudio-2.3.3.42-Debug.zip
<https://github.com/github/VisualStudio/files/1359158/GitHub.VisualStudio-2.3.3.42-Debug.zip>
I'm going to ask the user if this fixes the issue they were seeing.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1248 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/Ae--eyjEiQZXMqgttu_sxcRmHzyI9yFgks5spMIRgaJpZM4Pu82p>
.
|
a22fd26 to
d354ed4
Compare
|
@ethomson Thanks for your offer of help debugging. 😄 One user has tried a test build that updates from LibGit2Sharp 0.22 to 0.23.1 (and NativeBinaries.1.0.129 to 1.0.164). This initial report is encouraging. I'm awaiting feedback from another user. |
Also from LibGit2Sharp.NativeBinaries.1.0.129 to 1.0.164.
Hack to allow methods that are obsolete in LibGit2Sharp 0.23.1 to be called. #pragma warning disable 0612, 0618 This is a temparary workaround.
This is the latest stable release. Depends on LibGit2Sharp.NativeBinaries v1.0.185.
21c82e4 to
d620d23
Compare
|
Here's a build that includes this PR. |
|
This looks good to me @jcansdale 👍 Focused testing around fetching, pulling, pushing and checking out branches. |
| Name = DisplayName = branch.FriendlyName; | ||
| Repository = branch.IsRemote ? new LocalRepositoryModel(branch.Remote.Url) : repo; | ||
| #pragma warning disable 0618 // TODO: Replace `Branch.Remote` with `Repository.Network.Remotes[branch.RemoteName]`. | ||
| var remoteUrl = branch.Remote.Url; |
There was a problem hiding this comment.
A bug was introduced here. Remote will be null if IsRemote is false.
This issue was introduced in #1248.
This PR updates GHfVS to use the LibGit2Sharp v0.24 (the latest stable version).
https://github.com/libgit2/libgit2sharp/releases/tag/v0.24
There are a number of point
#pragma warning disable 0618statements, which allow us to use a few deprecated methods.Unfortunately some of the suggested replacement methods expect a
Repositoryobject rather than anIRepository. This makes mocking little more awkward. Rather than refactor a bunch of our code and tests, I opted to simply disable and document the warnings.The impetus to update was due the the following issue:
There have been reports (see #1244) of the following error on the GitHub pane:
Failed to mmap. No data written: Not enough storage is available to process this command.It looks like this might be related to the version of
LibGit2we're using. See comment by @ethomson here:https://stackoverflow.com/a/38918860/121348
libgit2/libgit2#3690
Fixes #1244