Allow obsolete LibGit2Sharp methods to be called

jcansdale · jcansdale · commit d354ed4485d9 · 2017-10-10T09:58:04.000+01:00
Hack to allow methods that are obsolete in LibGit2Sharp 0.23.1 to be called.
#pragma warning disable 0612, 0618

This is a temparary workaround.
diff --git a/src/GitHub.App/Services/GitClient.cs b/src/GitHub.App/Services/GitClient.cs
@@ -36,6 +36,7 @@ public GitClient(IGitHubCredentialProvider credentialProvider)
             };
         }
 
+#pragma warning disable 0612, 0618
         public Task Pull(IRepository repository)
         {
             Guard.ArgumentNotNull(repository, nameof(repository));
diff --git a/src/GitHub.App/Services/PullRequestService.cs b/src/GitHub.App/Services/PullRequestService.cs
@@ -101,6 +101,7 @@ public IObservable<Unit> Pull(ILocalRepositoryModel repository)
             });
         }
 
+#pragma warning disable 0612, 0618
         public IObservable<Unit> Push(ILocalRepositoryModel repository)
         {
             return Observable.Defer(async () =>
@@ -165,6 +166,7 @@ public IObservable<string> GetDefaultLocalBranchName(ILocalRepositoryModel repos
             });
         }
 
+#pragma warning disable 0612, 0618
         public IObservable<BranchTrackingDetails> CalculateHistoryDivergence(ILocalRepositoryModel repository, int pullRequestNumber)
         {
             return Observable.Defer(async () =>
diff --git a/src/GitHub.Exports/Models/BranchModel.cs b/src/GitHub.Exports/Models/BranchModel.cs
@@ -25,6 +25,7 @@ public BranchModel(Octokit.Branch branch, IRepositoryModel repo)
             Id = String.Format(CultureInfo.InvariantCulture, "{0}/{1}", Repository.Owner, Name);
         }
 
+#pragma warning disable 0612, 0618
         public BranchModel(LibGit2Sharp.Branch branch, IRepositoryModel repo)
         {
             Extensions.Guard.ArgumentNotNull(branch, nameof(branch));

Original file line number	Diff line number	Diff line change
`@@ -36,6 +36,7 @@ public GitClient(IGitHubCredentialProvider credentialProvider)`
`36`	`36`	`};`
`37`	`37`	`}`
`38`	`38`
	`39`	`+#pragma warning disable 0612, 0618`
`39`	`40`	`public Task Pull(IRepository repository)`
`40`	`41`	`{`
`41`	`42`	`Guard.ArgumentNotNull(repository, nameof(repository));`
Original file line number	Diff line number	Diff line change
`@@ -101,6 +101,7 @@ public IObservable<Unit> Pull(ILocalRepositoryModel repository)`
`101`	`101`	`});`
`102`	`102`	`}`
`103`	`103`
	`104`	`+#pragma warning disable 0612, 0618`
`104`	`105`	`public IObservable<Unit> Push(ILocalRepositoryModel repository)`
`105`	`106`	`{`
`106`	`107`	`return Observable.Defer(async () =>`
`@@ -165,6 +166,7 @@ public IObservable<string> GetDefaultLocalBranchName(ILocalRepositoryModel repos`
`165`	`166`	`});`
`166`	`167`	`}`
`167`	`168`
	`169`	`+#pragma warning disable 0612, 0618`
`168`	`170`	`public IObservable<BranchTrackingDetails> CalculateHistoryDivergence(ILocalRepositoryModel repository, int pullRequestNumber)`
`169`	`171`	`{`
`170`	`172`	`return Observable.Defer(async () =>`
Original file line number	Diff line number	Diff line change
`@@ -25,6 +25,7 @@ public BranchModel(Octokit.Branch branch, IRepositoryModel repo)`
`25`	`25`	`Id = String.Format(CultureInfo.InvariantCulture, "{0}/{1}", Repository.Owner, Name);`
`26`	`26`	`}`
`27`	`27`
	`28`	`+#pragma warning disable 0612, 0618`
`28`	`29`	`public BranchModel(LibGit2Sharp.Branch branch, IRepositoryModel repo)`
`29`	`30`	`{`
`30`	`31`	`Extensions.Guard.ArgumentNotNull(branch, nameof(branch));`