8000 Fix null reference when no remote branch by jcansdale · Pull Request #1273 · github/VisualStudio · GitHub
[go: up one dir, main page]

Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Fix null reference when no remote branch #1273

Merged
merged 2 commits into from
Oct 19, 2017

Conversation

jcansdale
Copy link
Collaborator
@jcansdale jcansdale commented Oct 18, 2017

This bug was introduced in #1248. It should check IsRemote before using Remote.Url. This was a mistranslation from the original code.

You can see where it was introduced here:
https://github.com/github/VisualStudio/pull/1248/files#diff-5cf03831f8fad074156df6626c3acc94L34

This issue was introduced in #1248.
@jcansdale jcansdale merged commit 02c6a94 into master Oct 19, 2017
@jcansdale jcansdale deleted the fixes/1248-null-exception-when-no-remote branch October 19, 2017 08:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0