"fix(typescript): Revert add overload types for find service methods (#1972)#2025
Merged
daffl<
8000
/a> merged 1 commit intocrowfrom Jul 24, 2020
Merged
"fix(typescript): Revert add overload types for find service methods (#1972)#2025
find service methods (#1972)#2025Conversation
daffl
added a commit
that referenced
this pull request
Jul 24, 2020
EliSadaka
pushed a commit
to yusernetwork/authentication-oauth
that referenced
this pull request
Oct 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request reverts #1972 which breaks some assumption for other adapters. It will be added in the adapter common types via https://github.com/feathersjs/databases/pull/9 instead.