8000 "fix(typescript): Revert add overload types for `find` service methods (#1972) by daffl · Pull Request #2025 · feathersjs/feathers · GitHub
[go: up one dir, main page]
Skip to content

"fix(typescript): Revert add overload types for find service methods (#1972) #2025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daffl merged 1 commit into from
Jul 24, 2020
Merged

"fix(typescript): Revert add overload types for find service methods (#1972) #2025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/authentication-oauth/src/strategy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,7 @@ export class OAuthStrategy extends AuthenticationBaseStrategy {
...params,
query
});

const [ entity = null ] = Array.isArray(result) ? result : result.data
const [ entity = null ] = result.data ? result.data : result;

debug('findEntity returning', entity);

Expand Down
16 changes: 0 additions & 16 deletions packages/feathers/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,22 +210,6 @@ declare namespace createApplication {
}

interface ServiceOverloads<T> {
/**
* Retrieve all resources from this service.
*
* @param params - Service call parameters {@link Params}
* @see {@link https://docs.feathersjs.com/api/services.html#find-params|Feathers API Documentation: .find(params)}
*/
find? (params: Params & { paginate: false}): Promise<T[]>

/**
* Retrieve all resources from this service.
*
* @param params - Service call parameters {@link Params}
* @see {@link https://docs.feathersjs.com/api/services.html#find-params|Feathers API Documentation: .find(params)}
*/
find? (params?: Params): Promise<Paginated<T>>

/**
* Create a new resource for this service.
*
Expand Down
0