E574 fix(typescript): Revert add overload types for `find` service methods… · feathersjs/feathers@a9501ac · GitHub
[go: up one dir, main page]

Skip to content

Commit a9501ac

Browse files
committed
fix(typescript): Revert add overload types for find service methods (#1972)" (#2025)
1 parent c838d8b commit a9501ac

File tree

2 files changed

+1
-18
lines changed

2 files changed

+1
-18
lines changed

packages/authentication-oauth/src/strategy.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,8 +103,7 @@ export class OAuthStrategy extends AuthenticationBaseStrategy {
103103
...params,
104104
query
105105
});
106-
107-
const [ entity = null ] = Array.isArray(result) ? result : result.data
106+
const [ entity = null ] = result.data ? result.data : result;
108107

109108
debug('findEntity returning', entity);
110109

packages/feathers/index.d.ts

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -210,22 +210,6 @@ declare namespace createApplication {
210210
}
211211

212212
interface ServiceOverloads<T> {
213-
/**
214-
* Retrieve all resources from this service.
215-
*
216-
* @param params - Service call parameters {@link Params}
217-
* @see {@link https://docs.feathersjs.com/api/services.html#find-params|Feathers API Documentation: .find(params)}
218-
*/
219-
find? (params: Params & { paginate: false}): Promise<T[]>
220-
221-
/**
222-
* Retrieve all resources from this service.
223-
*
224-
* @param params - Service call parameters {@link Params}
225-
* @see {@link https://docs.feathersjs.com/api/services.html#find-params|Feathers API Documentation: .find(params)}
226-
*/
227-
find? (params?: Params): Promise<Paginated<T>>
228-
229213
/**
230214
* Create a new resource for this service.
231215
*

0 commit comments

Comments
 (0)
0