8000 fix: do not convert & URL query separator to & by nichoski · Pull Request #7114 · django-cms/django-cms · GitHub
[go: up one dir, main page]
Skip to content

fix: do not convert & URL query separator to & #7114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 26, 2021
Merged

fix: do not convert & URL query separator to & #7114

merged 1 commit into from
Nov 26, 2021

Conversation

nichoski
Copy link
Contributor
@nichoski nichoski commented Aug 19, 2021 •
edited
Loading

Description

Do not convert & to & in URLs. This is fixing the problem described in issue 7113.

  • I have opened this pull request against develop
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on Slack to find a “pr review buddy” who is going to review my pull request.

@macolo macolo linked an issue Aug 19, 2021 that may be closed by this pull request
[BUG] Publish button disappears after plugin editing #7113
Closed
@nichoski nichoski force-pushed the 7113-disappearing-publish-button branch from ae79afd to f470461 Compare August 19, 2021 10:30
@marksweb marksweb self-requested a review August 19, 2021 13:08
@dkoenigroer dkoenigroer mentioned this pull request Nov 24, 2021
Closed
@crydotsnake crydotsnake merged commit c0c10e0 into django-cms:develop Nov 26, 2021
@fsbraun fsbraun mentioned this pull request Mar 29, 2022
Closed
4 tasks
@Aiky30
Copy link
Contributor
Aiky30 commented May 17, 2022

This change reverses a fix implemented here: #3404

This highlights the need for unit tests to be created that simulate the bug, then if there's any regression such as what this fix has addresses the original issue doesn't then show its head.

Bugs should always be delivered using Test Driven Ddevelopment (TDD)!

@fsbraun fsbraun mentioned this pull request May 17, 2022
Merged
4 tasks
This was referenced Jun 22, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marksweb marksweb marksweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Publish button disappears after plugin editing
4 participants
@nichoski @Aiky30 @marksweb @crydotsnake
0