fix: do not replace & with & in URLs #7115
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nichoski The fix looks legit, thought I am not convinced that it would work properly without bumping the version as well. To make sure it works fine, we need to bump the version and the generated files needs to build in a 3.7.5 directory to ensure there are no weird issues because of cached assets even on the new release. |
vinitkumar
requested changes
Oct 3, 2021
There was a problem hiding this comment.
@nichoski The fix looks legit, thought I am not convinced that it would work properly without bumping the version as well. To make sure it works fine, we need to bump the version and the generated files needs to build in a 3.7.5 directory to ensure there are no weird issues because of cached assets even on the new release.
|
Implemented by #7114 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Do not convert & to & in URLs. This is fixing the problem described in issue 7113. This is for branch release/3.7.x
develop