fix: Avoid unnecessary toolbar loading when editing #7282
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 592a2b6.
Fix: Avoid unnecessary toolbar loading
|
I like the sound of this 👌 |
|
@fsbraun Can we close this? Looks like we've had the changes come in elsewhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, each time an editing command (change, cut, paste, move a plugin etc.) is executed first the toolbar is updated by xhr request to the server, then the entire page content is reloaded including the toolbar.
This PR:
Does avoid double loading of toolbar thereby increasing overall responsiveness
Ensures the correct toolbar is fetched (given by the
cms_pathGET parameter) to avoid missing toolbar pieces.Remove a bit of legacy python2.7 code
Related resources
This PR is the diff between #7114 and #7272 on
develop-4.Checklist
develop