8000 better fix for the hidden on reference out of view. by xvaara · Pull Request #2370 · bootstrap-vue-next/bootstrap-vue-next · GitHub
[go: up one dir, main page]

Skip to content

better fix for the hidden on reference out of view. #2370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

xvaara
Copy link
Contributor
@xvaara xvaara commented Nov 21, 2024

BEGIN_COMMIT_OVERRIDE

fix(BModal,BOffcanvas): flicker when no animation and double animation when leaving with animation and backdrop-first

fix(BPopover): fix hide on reference hidden, fix close-on-hide.

END_COMMIT_OVERRIDE

Describe the PR

A clear and concise description of what the pull request does.

Small replication

A small replication or video walkthrough can help demonstrate the changes made. This is optional, but can help observe the intended changes. A mentioned issue that contains a replication also works.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix 🐛 - fix(...)
  • Feature - feat(...)
  • ARIA accessibility - fix(...)
  • Documentation update - docs(...)
  • Other (please describe)

The PR fulfills these requirements:

  • Pull request title and all commits follow the Conventional Commits convention or has an override in this pull request body This is very important, as the CHANGELOG is generated from these messages, and determines the next version type. Pull requests that do not follow conventional commits or do not have an override will be denied

fix(BModal,BOffcanvas): flicker when no animation and double animation when leaving with animation and backdrop-first

fix(BPopover): fix hide on reference hidden, fix close-on-hide.
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@xvaara xvaara merged commit 0f5375f into bootstrap-vue-next:main Nov 21, 2024
3 checks passed
Copy link
pkg-pr-new bot commented Nov 21, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/bootstrap-vue-next/bootstrap-vue-next@2370
pnpm add https://pkg.pr.new/bootstrap-vue-next/bootstrap-vue-next/@bootstrap-vue-next/nuxt@2370

commit: b48edf6

xvaara added a commit to xvaara/bootstrap-vue-next that referenced this pull request Nov 22, 2024
* upstream/main:
  chore: release main (bootstrap-vue-next#2371)
  perf: use a composable rather than BTransition component, eliminating a useless fragment (bootstrap-vue-next#2372)
  better fix for the hidden on reference out of view. (bootstrap-vue-next#2370)
  revert release-please upgrade
  Update release-please to v4
  better fix for the hidden on reference out of view. (bootstrap-vue-next#2369)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0