8000 Merge remote-tracking branch 'upstream/main' · xvaara/bootstrap-vue-next@93118d0 · GitHub
[go: up one dir, main page]
Skip to content

Commit 93118d0

Browse files
xvaaraxvaara
committed
Merge remote-tracking branch 'upstream/main'
* upstream/main: chore: release main (bootstrap-vue-next#2371) perf: use a composable rather than BTransition component, eliminating a useless fragment (bootstrap-vue-next#2372) better fix for the hidden on reference out of view. (bootstrap-vue-next#2370) revert release-please upgrade Update release-please to v4 better fix for the hidden on reference out of view. (bootstrap-vue-next#2369)
2 parents d53ca4e + 977eed3 commit 93118d0

File tree

23 files changed

+158
-285
lines changed

23 files changed

+158
-285
lines changed

‎.github/ISSUE_TEMPLATE/bug_report.yaml

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -35,21 +35,3 @@ body:
3535
- n/a
3636
validations:
3737
required: true
38-
- type: checkboxes
39-
id: checkboxes
40-
attributes:
41-
label: Validations
42-
description: Before submitting the issue, please make sure you do the following
43-
options:
44-
- label: Have tested with the latest version. This is still alpha version and sometime things change rapidly.
45-
required: true
46-
- label: Follow our [Code of Conduct](https://github.com/bootstrap-vue-next/bootstrap-vue-next/blob/main/CODE_OF_CONDUCT.md)
47-
required: true
48-
- label: Read the [Contributing Guide](https://github.com/bootstrap-vue-next/bootstrap-vue-next/blob/main/CONTRIBUTING.md).
49-
required: true
50-
- label: Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
51-
required: true
52-
- label: Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
53-
required: true
54-
- label: The provided reproduction is a [minimal reproducible](https://stackoverflow.com/help/minimal-reproducible-example) of the bug.
55-
required: true

‎.github/ISSUE_TEMPLATE/compatibility_report.yaml

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -32,21 +32,3 @@ body:
3232
placeholder: Feature description
3333
validations:
3434
required: true
35-
- type: checkboxes
36-
id: checkboxes
37-
attributes:
38-
label: Validations
39-
description: Before submitting the issue, please make sure you do the following
40-
options:
41-
- label: Have tested with the latest version. This is still alpha version and sometime things change rapidly.
42-
required: true
43-
- label: Follow our [Code of Conduct](https://github.com/bootstrap-vue-next/bootstrap-vue-next/blob/main/CODE_OF_CONDUCT.md)
44-
required: true
45-
- label: Read the [Contributing Guide](https://github.com/bootstrap-vue-next/bootstrap-vue-next/blob/main/CONTRIBUTING.md).
46-
required: true
47-
- label: Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
48-
required: true
49-
- label: Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
50-
required: true
51-
- label: The provided link is to the documentation of the missing feature.
52-
required: true

‎.github/ISSUE_TEMPLATE/feature_request.yaml

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -30,15 +30,3 @@ body:
3030
attributes:
3131
label: Additional context
3232
description: Any other context or screenshots about the feature request here.
33-
- type: checkboxes
34-
id: checkboxes
35-
attributes:
36-
label: Validations
37-
description: Before submitting the issue, please make sure you do the following
38-
options:
39-
- label: Follow our [Code of Conduct](https://github.com/bootstrap-vue-next/bootstrap-vue-next/blob/main/CODE_OF_CONDUCT.md)
40-
required: true
41-
- label: Read the [Contributing Guide](https://github.com/bootstrap-vue-next/bootstrap-vue-next/blob/main/CONTRIBUTING.md).
42-
required: true
43-
- label: Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
44-
required: true

‎.github/workflows/release-main.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,4 +81,4 @@ jobs:
8181
NODE_AUTH_TOKEN: ${{secrets.NPM_TOKEN_NUXT_PACKAGE}}
8282
NPM_CONFIG_PROVENANCE: true
8383
if: ${{ steps.release.outputs.releases_created && steps.release.outputs['packages/nuxt--release_created'] }}
84-
84+

‎.release-please-manifest.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
{
2-
"packages/bootstrap-vue-next": "0.26.1",
3-
"packages/nuxt": "0.26.1"
2+
"packages/bootstrap-vue-next": "0.26.2",
3+
"packages/nuxt": "0.26.2"
44
}

‎apps/docs/src/docs/components/overlay.md

Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -216,6 +216,44 @@ prop. When a value is provided for `bg-color`, the `variant` prop value is ignor
216216
By default, the overlay uses Bootstrap's fade transition when showing or hiding. You can disable the
217217
fade transition via adding the `no-fade` prop to `BOverlay`.
218218

219+
<!-- @dwgray this is the same as the first example, but it uses no-fade prop -->
220+
221+
<HighlightCard>
222+
<BOverlay no-fade :show="showOverlayEx1" rounded="sm">
223+
<BCard title="Card with overlay" :aria-hidden="showOverlayEx1 ? 'true' : null">
224+
<BCardText>Laborum consequat non elit enim exercitation cillum.</BCardText>
225+
<BCardText>Click the button to toggle the overlay:</BCardText>
226+
<BButton :disabled="showOverlayEx1" variant="primary" @click="showOverlayEx1 = true">
227+
Show overlay
228+
</BButton>
229+
</BCard>
230+
</BOverlay>
231+
<BButton class="mt-3" @click="showOverlayEx1 = !showOverlayEx1">Toggle overlay</BButton>
232+
<template #html>
233+
234+
```vue
235+
<template>
236+
<BOverlay no-fade :show="showOverlayEx1" rounded="sm">
237+
<BCard title="Card with overlay" :aria-hidden="showOverlayEx1 ? 'true' : null">
238+
<BCardText>Laborum consequat non elit enim exercitation cillum.</BCardText>
239+
<BCardText>Click the button to toggle the overlay:</BCardText>
240+
<BButton :disabled="showOverlayEx1" variant="primary" @click="showOverlayEx1 = true">
241+
Show overlay
242+
</BButton>
243+
</BCard>
244+
</BOverlay>
245+
246+
<BButton @click="showOverlayEx1 = !showOverlayEx1">Toggle overlay</BButton>
247+
</template>
248+
249+
<script setup lang="ts">
250+
const showOverlayEx1 = ref(false)
251+
</script>
252+
```
253+
254+
</template>
255+
</HighlightCard>
256+
219257
### Default spinner styling
220258

221259
The default overlay content is a [`BSpinner`](/docs/components/spinner) of type `'border'`. You

‎packages/bootstrap-vue-next/CHANGELOG.md

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,18 @@
11
# Changelog
22

3+
## [0.26.2](https://github.com/bootstrap-vue-next/bootstrap-vue-next/compare/bootstrapvuenext-v0.26.1...bootstrapvuenext-v0.26.2) (2024-11-21)
4+
5+
6+
### Bug Fixes
7+
8+
* **BModal,BOffcanvas:** flicker when no animation and double animation when leaving with animation and backdrop-first ([0f5375f](https://github.com/bootstrap-vue-next/bootstrap-vue-next/commit/0f5375f259fd1c750efc265345b46f77fa061106))
9+
* **BPopover:** fix hide on reference hidden, fix close-on-hide. ([0f5375f](https://github.com/bootstrap-vue-next/bootstrap-vue-next/commit/0f5375f259fd1c750efc265345b46f77fa061106))
10+
11+
12+
### Performance Improvements
13+
14+
* use a composable rather than BTransition component, eliminating a useless fragment ([#2372](https://github.com/bootstrap-vue-next/bootstrap-vue-next/issues/2372)) ([a788a2d](https://github.com/bootstrap-vue-next/bootstrap-vue-next/commit/a788a2d6f1910221472e0bddb39e9029ec9f1a9b))
15+
316
## [0.26.1](https://github.com/bootstrap-vue-next/bootstrap-vue-next/compare/bootstrapvuenext-v0.26.0...bootstrapvuenext-v0.26.1) (2024-11-20)
417

518

‎packages/bootstrap-vue-next/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "bootstrap-vue-next",
33
"displayName": "BootstrapVueNext",
44
"description": "BootstrapVueNext is an early and lovely component library for Vue 3 & Nuxt 3 based on Bootstrap 5 and Typescript.",
5-
"version": "0.26.1",
5+
"version": "0.26.2",
66
"license": "MIT",
77
"main": "./dist/bootstrap-vue-next.umd.js",
88
"module": "./dist/bootstrap-vue-next.mjs",

‎packages/bootstrap-vue-next/src/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212

1313
### Examples
1414

15-
- **Private File**: `./src/components/BTransition.vue` is a private file and is not exported from the library.
15+
- **Private File**: `./src/components/BCardHeadFoot.vue` is a private file and is not exported from the library.
1616
- **Public File**: `./src/components/BTooltip/BTooltip.vue` is a public file and is exported to users.
1717

1818
### Special Cases

‎packages/bootstrap-vue-next/src/components/BAlert/BAlert.vue

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<template>
2-
<BTransition :no-fade="!props.fade" :trans-props="{enterToClass: 'show'}">
2+
<Transition v-bind="fadeTransitions" enter-to-class="show">
33
<div
44
v-if="isAlertVisible"
55
ref="_element"
@@ -19,11 +19,10 @@
1919
<BCloseButton v-else :aria-label="props.closeLabel" v-bind="closeAttrs" @click="hide" />
2020
</template>
2121
</div>
22-
</BTransition>
22+
</Transition>
2323
</template>
2424

2525
<script setup lang="ts">
26-
import BTransition from '../BTransition.vue'
2726
import BCloseButton from '../BButton/BCloseButton.vue'
2827
import BButton from '../BButton/BButton.vue'
2928
import type {BAlertProps} from '../../types/ComponentProps'
@@ -32,6 +31,7 @@ import {useCountdown} from '../../composables/useCountdown'
3231
import {useDefaults} from '../../composables/useDefaults'
3332
import {isEmptySlot} from '../../utils/dom'
3433
import {useCountdownHover} from '../../composables/useCountdownHover'
34+
import {useFadeTransition} from '../../composables/useTransitions'
3535
3636
const _props = withDefaults(defineProps<Omit<BAlertProps, 'modelValue'>>(), {
3737
closeClass: undefined,
@@ -63,6 +63,8 @@ const slots = defineSlots<{
6363
default?: (props: Record<string, never>) => any
6464
}>()
6565
66+
const fadeTransitions = useFadeTransition(() => props.fade)
67+
6668
const element = useTemplateRef<HTMLElement>('_element')
6769
6870
const modelValue = defineModel<Exclude<BAlertProps['modelValue'], undefined>>({default: false})

0 commit comments

Comments
 (0)
0