perf: use a composable rather than BTransition component, eliminating… #2372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a useless fragment
|
|
commit: |
Merged
|
@VividLemon I'm against this... adding css again, css that doesn't even use bootstrap variables. |
BTransition consumed components already use this CSS anyways. There is no real difference between before/after this change besides eliminating It could be a good idea to refactor to use actual bootstrap classes, if at all possible. But on the other hand to that, |
xvaara
added a commit
to xvaara/bootstrap-vue-next
that referenced
this pull request
Nov 22, 2024
* upstream/main: chore: release main (bootstrap-vue-next#2371) perf: use a composable rather than BTransition component, eliminating a useless fragment (bootstrap-vue-next#2372) better fix for the hidden on reference out of view. (bootstrap-vue-next#2370) revert release-please upgrade Update release-please to v4 better fix for the hidden on reference out of view. (bootstrap-vue-next#2369)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… a useless fragment
Describe the PR
A clear and concise description of what the pull request does.
Small replication
A small replication or video walkthrough can help demonstrate the changes made. This is optional, but can help observe the intended changes. A mentioned issue that contains a replication also works.
PR checklist
What kind of change does this PR introduce? (check at least one)
fix(...)feat(...)fix(...)docs(...)The PR fulfills these requirements:
CHANGELOGis generated from these messages, and determines the next version type. Pull requests that do not follow conventional commits or do not have an override will be denied