fix(BModal): fix backdrop when modal is shown using v-if #2269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
VividLemon
approved these changes
Oct 14, 2024
commit: |
xvaara
added a commit
to xvaara/bootstrap-vue-next
that referenced
this pull request
Oct 16, 2024
* upstream/main: chore: release main (bootstrap-vue-next#2275) fix(BFormCheckbox): indeterminate state not working properly fixes bootstrap-vue-next#2271 (bootstrap-vue-next#2274) chore: release main (bootstrap-vue-next#2270) fix(BModal): fix backdrop when modal is shown using v-if (bootstrap-vue-next#2269) chore: release main (bootstrap-vue-next#2259) fix(BFormInput): bad model modifier trim behavior fixes bootstrap-vue-next#2253 (bootstrap-vue-next#2267) fix(BModal): multiple modals backdrop fix (bootstrap-vue-next#2263) feat: clean deprecated classes and props from bootstrap (sr-only => visually-hidden) docs(BDropdown): Fill out component references for subcomponents (bootstrap-vue-next#2265) feat(BDropdown): add variant, classes and correct attrs to text sub components (bootstrap-vue-next#2258) fix(BModal): fix backdrop click prevention, fix flickering when no-fade (bootstrap-vue-next#2262) fix(BPopover): calculate mouse and element positions in a performant way (bootstrap-vue-next#2252)
xvaara
added a commit
to xvaara/bootstrap-vue-next
that referenced
this pull request
Oct 21, 2024
* upstream/main: test: form checkbox indeterminate behavior (bootstrap-vue-next#2279) chore: release main (bootstrap-vue-next#2278) fix(BModal): remove scrolllock on unmount (bootstrap-vue-next#2277) chore: release main (bootstrap-vue-next#2275) fix(BFormCheckbox): indeterminate state not working properly fixes bootstrap-vue-next#2271 (bootstrap-vue-next#2274) chore: release main (bootstrap-vue-next#2270) fix(BModal): fix backdrop when modal is shown using v-if (bootstrap-vue-next#2269) chore: release main (bootstrap-vue-next#2259) fix(BFormInput): bad model modifier trim behavior fixes bootstrap-vue-next#2253 (bootstrap-vue-next#2267) fix(BModal): multiple modals backdrop fix (bootstrap-vue-next#2263) feat: clean deprecated classes and props from bootstrap (sr-only => visually-hidden) docs(BDropdown): Fill out component references for subcomponents (bootstrap-vue-next#2265) feat(BDropdown): add variant, classes and correct attrs to text sub components (bootstrap-vue-next#2258) fix(BModal): fix backdrop click prevention, fix flickering when no-fade (bootstrap-vue-next#2262)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Adds
:appear="modelValue"to the backdrop teleport so the after-enter event which shows the backdrop is fired upon initial render. This matches the behavior of the modal teleport itself -- it also has that same attribute set.fixes #2268
Small replication
A small replication or video walkthrough can help demonstrate the changes made. This is optional, but can help observe the intended changes. A mentioned issue that contains a replication also works.
PR checklist
What kind of change does this PR introduce? (check at least one)
fix(...)feat(...)fix(...)docs(...)The PR fulfills these requirements:
CHANGELOGis generated from these messages, and determines the next version type. Pull requests that do not follow conventional commits or do not have an override will be denied