8000 fix(BModal): fix backdrop click prevention, fix flickering when no-fade by xvaara · Pull Request #2262 · bootstrap-vue-next/bootstrap-vue-next · GitHub
[go: up one dir, main page]

Skip to content

fix(BModal): fix backdrop click prevention, fix flickering when no-fade #2262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2024

Conversation

xvaara
Copy link
Contributor
@xvaara xvaara commented Oct 12, 2024

Describe the PR

closes #2260

Small replication

A small replication or video walkthrough can help demonstrate the changes made. This is optional, but can help observe the intended changes. A mentioned issue that contains a replication also works.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix 🐛 - fix(...)
  • Feature - feat(...)
  • ARIA accessibility - fix(...)
  • Documentation update - docs(...)
  • Other (please describe)

The PR fulfills these requirements:

  • Pull request title and all commits follow the Conventional Commits convention or has an override in this pull request body This is very important, as the CHANGELOG is generated from these messages, and determines the next version type. Pull requests that do not follow conventional commits or do not have an override will be denied

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
pkg-pr-new bot commented Oct 12, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/bootstrap-vue-next/bootstrap-vue-next@2262
pnpm add https://pkg.pr.new/bootstrap-vue-next/bootstrap-vue-next/@bootstrap-vue-next/nuxt@2262

commit: 4bfb43c

@xvaara xvaara merged commit e008cf4 into bootstrap-vue-next:main Oct 12, 2024
4 checks passed
@github-actions github-actions bot mentioned this pull request Oct 11, 2024
xvaara added a commit to xvaara/bootstrap-vue-next that referenced this pull request Oct 16, 2024
* upstream/main:
  chore: release main (bootstrap-vue-next#2275)
  fix(BFormCheckbox): indeterminate state not working properly fixes bootstrap-vue-next#2271 (bootstrap-vue-next#2274)
  chore: release main (bootstrap-vue-next#2270)
  fix(BModal): fix backdrop when modal is shown using v-if (bootstrap-vue-next#2269)
  chore: release main (bootstrap-vue-next#2259)
  fix(BFormInput): bad model modifier trim behavior fixes bootstrap-vue-next#2253 (bootstrap-vue-next#2267)
  fix(BModal): multiple modals backdrop fix (bootstrap-vue-next#2263)
  feat: clean deprecated classes and props from bootstrap (sr-only => visually-hidden)
  docs(BDropdown): Fill out component references for subcomponents (bootstrap-vue-next#2265)
  feat(BDropdown): add variant, classes and correct attrs to text sub components (bootstrap-vue-next#2258)
  fix(BModal): fix backdrop click prevention, fix flickering when no-fade (bootstrap-vue-next#2262)
  fix(BPopover): calculate mouse and element positions in a performant way (bootstrap-vue-next#2252)
xvaara added a commit to xvaara/bootstrap-vue-next that referenced this pull request Oct 21, 2024
* upstream/main:
  test: form checkbox indeterminate behavior (bootstrap-vue-next#2279)
  chore: release main (bootstrap-vue-next#2278)
  fix(BModal): remove scrolllock on unmount (bootstrap-vue-next#2277)
  chore: release main (bootstrap-vue-next#2275)
  fix(BFormCheckbox): indeterminate state not working properly fixes bootstrap-vue-next#2271 (bootstrap-vue-next#2274)
  chore: release main (bootstrap-vue-next#2270)
  fix(BModal): fix backdrop when modal is shown using v-if (bootstrap-vue-next#2269)
  chore: release main (bootstrap-vue-next#2259)
  fix(BFormInput): bad model modifier trim behavior fixes bootstrap-vue-next#2253 (bootstrap-vue-next#2267)
  fix(BModal): multiple modals backdrop fix (bootstrap-vue-next#2263)
  feat: clean deprecated classes and props from bootstrap (sr-only => visually-hidden)
  docs(BDropdown): Fill out component references for subcomponents (bootstrap-vue-next#2265)
  feat(BDropdown): add variant, classes and correct attrs to text sub components (bootstrap-vue-next#2258)
  fix(BModal): fix backdrop click prevention, fix flickering when no-fade (bootstrap-vue-next#2262)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: BModals no longer respect the "no-close-on-backdrop" attribute since version 0.25
1 participant
0