10000 fix(BPopover): calculate mouse and element positions in a performant way by xvaara · Pull Request #2252 · bootstrap-vue-next/bootstrap-vue-next · GitHub
[go: up one dir, main page]

Skip to content

fix(BPopover): calculate mouse and element positions in a performant way #2252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 11, 2024

Conversation

xvaara
Copy link
Contributor
@xvaara xvaara commented Oct 7, 2024

feat(BPopover): add prop hideMargin

Describe the PR

A clear and concise description of what the pull request does.

Small replication

A small replication or video walkthrough can help demonstrate the changes made. This is optional, but can help observe the intended changes. A mentioned issue that contains a replication also works.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix 🐛 - fix(...)
  • Feature - feat(...)
  • ARIA accessibility - fix(...)
  • Documentation update - docs(...)
  • Other (please describe)

The PR fulfills these requirements:

  • Pull request title and all commits follow the Conventional Commits convention or has an override in this pull request body This is very important, as the CHANGELOG is generated from these messages, and determines the next version type. Pull requests that do not follow conventional commits or do not have an override will be denied

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@xvaara xvaara linked an issue Oct 7, 2024 that may be closed by this pull request
6 tasks
Copy link
pkg-pr-new bot commented Oct 7, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/bootstrap-vue-next/bootstrap-vue-next@2252
pnpm add https://pkg.pr.new/bootstrap-vue-next/bootstrap-vue-next/@bootstrap-vue-next/nuxt@2252

commit: cccd4c0

@xvaara xvaara requested a review from VividLemon October 8, 2024 12:24
@xvaara
Copy link
Contributor Author
xvaara commented Oct 8, 2024

@xvaara xvaara merged commit bc4df5f into bootstrap-vue-next:main Oct 11, 2024
4 checks passed
@xvaara xvaara deleted the popover-performance branch October 11, 2024 13:00
@github-actions github-actions bot mentioned this pull request Oct 11, 2024
xvaara added a commit to xvaara/bootstrap-vue-next that referenced this pull request Oct 11, 2024
* upstream/main:
  fix(BPopover): calculate mouse and element positions in a performant way (bootstrap-vue-next#2252)
xvaara added a commit to xvaara/bootstrap-vue-next that referenced this pull request Oct 16, 2024
* upstream/main:
  chore: release main (bootstrap-vue-next#2275)
  fix(BFormCheckbox): indeterminate state not working properly fixes bootstrap-vue-next#2271 (bootstrap-vue-next#2274)
  chore: release main (bootstrap-vue-next#2270)
  fix(BModal): fix backdrop when modal is shown using v-if (bootstrap-vue-next#2269)
  chore: release main (bootstrap-vue-next#2259)
  fix(BFormInput): bad model modifier trim behavior fixes bootstrap-vue-next#2253 (bootstrap-vue-next#2267)
  fix(BModal): multiple modals backdrop fix (bootstrap-vue-next#2263)
  feat: clean deprecated classes and props from bootstrap (sr-only => visually-hidden)
  docs(BDropdown): Fill out component references for subcomponents (bootstrap-vue-next#2265)
  feat(BDropdown): add variant, classes and correct attrs to text sub components (bootstrap-vue-next#2258)
  fix(BModal): fix backdrop click prevention, fix flickering when no-fade (bootstrap-vue-next#2262)
  fix(BPopover): calculate mouse and element positions in a performant way (bootstrap-vue-next#2252)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance dropped when use many tooltip directives or popovers
1 participant
0