-
-
Notifications
You must be signed in to change notification settings - Fork 151
doc(BDropdown): Parity pass on component and helpers #2243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
VividLemon
requested changes
Oct 3, 2024
Co-authored-by: Issayah <github.me.mzu5a@simplelogin.com>
commit: |
VividLemon
approved these changes
Oct 4, 2024
xvaara
added a commit
to xvaara/bootstrap-vue-next
that referenced
this pull request
Oct 10, 2024
* upstream/main: (27 commits) fix(vBPopover): revert bootstrap-vue-next#2234 (bootstrap-vue-next#2256) fix(BModal): fix backdrop, fade and reduced animation (bootstrap-vue-next#2250) fix(BTable): busy slot behavior to match bootstrap-vue fixes bootstrap-vue-next#1636 (bootstrap-vue-next#2249) fix(BTable): cast formatted items to string fixes bootstrap-vue-next#2227 (bootstrap-vue-next#2247) doc(BDropdown): Parity pass on component and helpers (bootstrap-vue-next#2243) fix(BTable): use watcher to compare changes with selectedItems fixes bootstrap-vue-next#2245 (bootstrap-vue-next#2246) fix(BTable)!: rename event row-dbl-clicked to row-dblclicked (bootstrap-vue-next#2239) docs: Work around unplugin bug (bootstrap-vue-next#2226) docs(BCollapse): Parity pass (bootstrap-vue-next#2237) fix directives in vite template chore: release main (bootstrap-vue-next#2235) fix(vBPopover): add position absolute to floating directives (bootstrap-vue-next#2234) chore: release main (bootstrap-vue-next#2231) fix(BTable): select mode range when table is sorted fixes bootstrap-vue-next#2229 (bootstrap-vue-next#2230) Update migration-guide.md chore: release main (bootstrap-vue-next#2223) refactor(useColorVariantClasses): add border variants into its resolver (bootstrap-vue-next#2224) feat(colorvariant): add subtle and emphasis variant fixes bootstrap-vue-next#2079 chore: release main (bootstrap-vue-next#2220) fix(BModal): fix jumping when scrollbars are present (bootstrap-vue-next#2211) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
In addition
I made slots, emits and slot scoped args optional in the documentation - there are plenty of places where these are empty and it's just cleaner to not have to specify empty arrays.
Small replication
A small replication or video walkthrough can help demonstrate the changes made. This is optional, but can help observe the intended changes. A mentioned issue that contains a replication also works.
PR checklist
What kind of change does this PR introduce? (check at least one)
fix(...)
feat(...)
fix(...)
docs(...)
The PR fulfills these requirements:
CHANGELOG
is generated from these messages, and determines the next version type. Pull requests that do not follow conventional commits or do not have an override will be denied