8000 doc(BDropdown): Parity pass on component and helpers by dwgray · Pull Request #2243 · bootstrap-vue-next/bootstrap-vue-next · GitHub
[go: up one dir, main page]
Skip to content

doc(BDropdown): Parity pass on component and helpers #2243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 4, 2024
Merged

doc(BDropdown): Parity pass on component and helpers #2243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8f03f79
docs(BDropdown): Refactor and parity pass
dwgray Oct 1, 2024
7b3f184
docs(BDropdown): Fill out component reference
dwgray Oct 3, 2024
65e7e21
docs: make some of the ComponentProps values optional
dwgray Oct 3, 2024
df4c37e
docs(BDropdown): Fill out component reference for helpers
dwgray Oct 3, 2024
250c303
Update apps/docs/src/docs/components/dropdown.md
dwgray Oct 3, 2024
72606b3
docs(BDropdown): Fix doc build issue
dwgray Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/docs/src/components/ComponentReference.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,8 +256,8 @@ const sortData = computed(() =>
.map(([key, value]) => ({prop: kebabCase(key), ...value}))
.sort((a, b) => a.prop.localeCompare(b.prop)),
})),
emits: el.emits.sort((a, b) => a.event.localeCompare(b.event)),
slots: el.slots.sort((a, b) => a.name.localeCompare(b.name)),
emits: el.emits?.sort((a, b) => a.event.localeCompare(b.event)),
slots: el.slots?.sort((a, b) => a.name.localeCompare(b.name)),
}

data.sections = (['Properties', 'Events', 'Slots'] as ComponentSection[]).filter(
Expand Down
7 changes: 1 addition & 6 deletions apps/docs/src/data/components/accordion.data.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,19 +136,14 @@ export default {
default: false,
description: 'When true, the AccordionItem will be visible',
},
wrapperAttrs: {
type: 'Readonly<AttrsValue>',
default: undefined,
description: 'Attributes to be applied to the wrapper element',
},
...pick(
buildCommonProps({
id: {
description:
'The Id to be injected to accordion items and used to in BCollapse for state managment',
},
}),
['id', 'tag']
['id', 'tag', 'wrapperAttrs']
),
} satisfies Record<keyof BvnComponentProps['BAccordionItem'], PropertyReference>,
},
Expand Down
Loading
Loading
0