8000 fix(BModal): fix jumping when scrollbars are present by xvaara · Pull Request #2211 · bootstrap-vue-next/bootstrap-vue-next · GitHub
[go: up one dir, main page]

Skip to content

fix(BModal): fix jumping when scrollbars are present #2211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 21, 2024

Conversation

xvaara
Copy link
Contributor
@xvaara xvaara commented Sep 17, 2024

Describe the PR

I added a "lockRegistry" so that if we have multible locks, lifting one doesn't "lift" all.

closes #1953

Small replication

A small replication or video walkthrough can help demonstrate the changes made. This is optional, but can help observe the intended changes. A mentioned issue that contains a replication also works.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix 🐛 - fix(...)
  • Feature - feat(...)
  • ARIA accessibility - fix(...)
  • Documentation update - docs(...)
  • Other (please describe)

The PR fulfills these requirements:

  • Pull request title and all commits follow the Conventional Commits convention or has an override in this pull request body This is very important, as the CHANGELOG is generated from these messages, and determines the next version type. Pull requests that do not follow conventional commits or do not have an override will be denied

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@xvaara xvaara requested a review from VividLemon September 17, 2024 20:48
Copy link
pkg-pr-new bot commented Sep 17, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/bootstrap-vue-next/bootstrap-vue-next@2211
pnpm add https://pkg.pr.new/bootstrap-vue-next/bootstrap-vue-next/@bootstrap-vue-next/nuxt@2211

commit: 93e7b91

Copy link
Member
@VividLemon VividLemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this seems fine. The code is kinda weird but seems good and likely best

@VividLemon VividLemon merged commit 9ab6132 into bootstrap-vue-next:main Sep 21, 2024
4 checks passed
@github-actions github-actions bot mentioned this pull request Sep 21, 2024
xvaara added a commit to xvaara/bootstrap-vue-next that referenced this pull request Oct 10, 2024
* upstream/main: (27 commits)
  fix(vBPopover): revert bootstrap-vue-next#2234 (bootstrap-vue-next#2256)
  fix(BModal): fix backdrop, fade and reduced animation (bootstrap-vue-next#2250)
  fix(BTable): busy slot behavior to match bootstrap-vue fixes bootstrap-vue-next#1636  (bootstrap-vue-next#2249)
  fix(BTable): cast formatted items to string fixes bootstrap-vue-next#2227 (bootstrap-vue-next#2247)
  doc(BDropdown): Parity pass on component and helpers (bootstrap-vue-next#2243)
  fix(BTable): use watcher to compare changes with selectedItems fixes bootstrap-vue-next#2245 (bootstrap-vue-next#2246)
  fix(BTable)!: rename event row-dbl-clicked to row-dblclicked (bootstrap-vue-next#2239)
  docs: Work around unplugin bug (bootstrap-vue-next#2226)
  docs(BCollapse): Parity pass (bootstrap-vue-next#2237)
  fix directives in vite template
  chore: release main (bootstrap-vue-next#2235)
  fix(vBPopover): add position absolute to floating directives (bootstrap-vue-next#2234)
  chore: release main (bootstrap-vue-next#2231)
  fix(BTable): select mode range when table is sorted fixes bootstrap-vue-next#2229 (bootstrap-vue-next#2230)
  Update migration-guide.md
  chore: release main (bootstrap-vue-next#2223)
  refactor(useColorVariantClasses): add border variants into its resolver (bootstrap-vue-next#2224)
  feat(colorvariant): add subtle and emphasis variant fixes bootstrap-vue-next#2079
  chore: release main (bootstrap-vue-next#2220)
  fix(BModal): fix jumping when scrollbars are present (bootstrap-vue-next#2211)
  ...
@xvaara xvaara deleted the modal-jump-fix branch October 13, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Content shifts right/left when modal opens/closes on pages with a vertical scrollbar.
2 participants
0