-
-
Notifications
You must be signed in to change notification settings - Fork 597
feat(bzlmod): Add a gazelle example #969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This changes the label strings that the users would get when loading the `all_requirements` and `all_whl_requirements` from the generated `requirements.bzl`. Previous labels were not really useable under bzlmod, because they would not be visible to the consumer. Work towards bazel-contrib#965
Allow setting conventions for each part of the external repo labels. This is also useful when creating multi-platform alias targets when using an approach described in 2022 bazelcon [1]. [1]: https://www.youtube.com/watch?v=Bjaiu8tZZhs Work towards bazel-contrib#965.
Work towards bazel-contrib#965.
c8cc46a to
89a8c6b
Compare
|
Now also depends on #970 |
|
@aignas I was talking with @alexeagle, and he mentioned that we should only support one example. In the README.md we make a reference to the commit that contains the pre bzmod example. Thoughts? |
|
No I think the rules repo needs examples for WORKSPACE and MODULE.bazel for a couple years while users are migrating. My comment was about only maintaining one tutorial. |
|
@alexeagle, thanks for the clarification! |
|
This is getting stale, so I'll close this in favour of something else in the somewhat near future. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
There is no example on the
gazellesetup withbzlmod.Issue Number: #965
What is the new behavior?
This is the example.
Does this PR introduce a breaking change?
Other information
Depends on #966, #967, #968.