8000 feat(gazelle): Allow customizing pip repo target naming convention by aignas · Pull Request #967 · bazel-contrib/rules_python · GitHub
[go: up one dir, main page]
Skip to content

feat(gazelle): Allow customizing pip repo target naming convention #967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

feat(gazelle): Allow customizing pip repo target naming convention #967

wants to merge 3 commits into from

Conversation

aignas
Copy link
Collaborator
@aignas aignas commented Jan 3, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Currently the external pip dependency convention is hardcoded to @$repo_name$_$distribution_name$//:pkg, which makes it not flexible enough to be used together with bzlmod and/or multi-platform builds (as per [1]).

Work towards #965.

What is the new behavior?

Allow setting conventions for each part of the external repo labels. This is also useful when creating multi-platform alias targets when using an approach described in 2022 bazelcon [1]. See the added docs in gazelle/README.md.

Does this PR introduce a breaking change?

  • Yes
  • No

@aignas
feat(gazelle): Allow customizing pip repo target naming convention
4c38894 
Allow setting conventions for each part of the external repo labels.
This is also useful when creating multi-platform alias targets when
using an approach described in 2022 bazelcon [1].

[1]: https://www.youtube.com/watch?v=Bjaiu8tZZhs

Work towards bazel-contrib#965.
@aignas aignas requested a review from f0rmiga as a code owner January 3, 2023 04:18
This was referenced Jan 3, 2023
Closed
Closed
@aignas aignas marked this pull request as draft January 5, 2023 08:56
@aignas aignas mentioned this pull request Jan 11, 2023
Closed
@aignas aignas closed this Feb 13, 2023
@aignas aignas deleted the gazelle-bzlmod-2 branch February 13, 2023 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f0rmiga f0rmiga Awaiting requested review from f0rmiga

@dougthor42 dougthor42 Awaiting requested review from dougthor42 dougthor42 will be requested when the pull request is marked ready for review dougthor42 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aignas
0