feat(gazelle): support bzlmod #968
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 3, 2023
|
Depends on #972. |
f5db73a to
58a7a2f
Compare
Summary: * Move go.mod to gazelle. * Move gazelle definition. * Move the gazelle plugin to a separate folder, just like bazel-skylib does, which helps with naming of the externally visible targets. * Fix file distribution for the gazelle module. * Update the example test. * Include rules_python_gazelle_plugin during integration tests * Update ignored packages * Update CI configuration
Work towards bazel-contrib#965
58a7a2f to
d4c25b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently
rules_pythonis missing dependencies required for the gazelle plugin operation.Work towards #965.
What is the new behavior?
The extra dependencies have been added.
Does this PR introduce a breaking change?
Other information
I saw that the gazelle plugin for
bazel-skylibhas a separateMODULE.bazelfile and maybe we should follow that route. However, I assume that they have gone with that approach due tobazel-skylibbeing a much more low-level dependency thanrules_python. Hence I chose the monolithic approach for now. Whichever approach we take here, it may need to be consistent with #832 of how thepy_proto_librarysupport is introduced.