Bug fix/agency compactor deadlock #3335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ObiWahn
added a commit
that referenced
this pull request
Sep 29, 2017
…ult-cache * origin: (85 commits) rework process handling (#3322) Bug fix/agency compactor deadlock (#3335) restore the feature to be able to specify the CXX via the environment. (#3340) try to work around some assertions (#3296) Feature/jenkins pipeline (#3338) Feature/switch to 3.3 (#3336) Bug fix/sort out agency locks (#3306) Revert "shut down the second instance properly (#3332)" Revert "Bugfix/fix test arangod shutdown command (#3260)" fixed duplicate variable fixed links in results.html overview fixed jslint fixed missing cleanBuild check shut down the second instance properly (#3332) Feature/jenkins pipeline (#3327) increase default value for /proc/sys/vm/max_map_count (#3321) show warnings if curl work thread is blocked by error/success cbs (#3316) During the startup of arangod the client will fail to connect. (#3302) set minimum required GCC version to 5.4 (#3298) Feature/mmfiles hash lookup performance (#3265) ...
neunhoef
added a commit
that referenced
this pull request
Oct 22, 2017
* Fix a deadlock between Agent thread and compactor thread. * Improve comments in header. * Organise clean shutdown of agency threads.
neunhoef
added a commit
that referenced
this pull request
Oct 24, 2017
* Fix a deadlock between Agent thread and compactor thread. * Improve comments in header. * Organise clean shutdown of agency threads.
jsteemann
pushed a commit
that referenced
this pull request
Oct 26, 2017
* Revert "Return the result of the inquiry (#3472)" This reverts commit 1dc1a98. * Revert "cherry picking of bug-fix/agency-restart-after-compaction-and-holes-i… (#3423)" This reverts commit 324184d. * State has to keep log for removeConflicts and acoording log all the way (#3249) * Bug fix/sort out agency locks (#3306) New locking concept in Agency. Ensure empty heartbeats can be sent, answered and processed without long locks. Adjust logging. Fix compaction bugs. * Bug fix/agency compactor deadlock (#3335) * Fix a deadlock between Agent thread and compactor thread. * Improve comments in header. * Organise clean shutdown of agency threads. * Bug fix/agency leader timeouts (#3373) * Send out empty heartbeats regardless of non-empty AppendEntriesRPC. * Also improve logging: Note if a log in the empty heartbeat sending takes > 0.01 s. Clearly mark places where a leader resigns in logging. Log if no empty heartbeat is sent out. * Make leader more tolerant w.r.t. incoming AppendEntriesRPC responses. * Add debug logging for _lastAcked and challengeLeadership. * Remove some unused code. Do not count ourselves in challengeLeadership. * Removal of entire activation/deactivation mechanisms in agency * TRI_microtime up to c++11 * added term to response to sendAppendEntries. * Bug fix/agency restart after compaction and holes in log (#3413) * State fixes holes in RAFT index range * Avoid application of entries older than compaction index _cur and guard for unsigned overflow * Return the result of the inquiry (#3465) * Add a hidden AGENCY_DUMP for agency emergency recovery. (#3474) * Port more changes from devel to 3.2. This could not be cherry-picked, since the changes concerning the agency were in squash commits which touch a lot of different things. * Make members private in AgentConfiguration * Log update of agency configuration. * Do not deal with active in gossip phase. * Take out some debugging output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a possible deadlock between the compactor thread and the agent thread. Furthermore, the agent main thread now waits for all its agency subthreads to terminate at shutdown.