8000 cherry picking of bug-fix/agency-restart-after-compaction-and-holes-i… by kvahed · Pull Request #3423 · arangodb/arangodb · GitHub
[go: up one dir, main page]

Skip to content

cherry picking of bug-fix/agency-restart-after-compaction-and-holes-i… #3423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kvahed
Copy link
Contributor
@kvahed kvahed commented Oct 16, 2017

Cherry picking agency bug fix where holes in RAFT Log lead to incapacitated agency.

@kvahed
Copy link
Contributor Author
kvahed commented Oct 16, 2017

Tests have completed on Linux and Mac.
The agency as delivered by customer starts up fine within 2-3 election cycles.
Leader maintains leadership through deployments of 10000+ log messages.

@kvahed kvahed merged commit 324184d into 3.2 Oct 16, 2017
neunhoef added a commit that referenced this pull request Oct 22, 2017
neunhoef added a commit that referenced this pull request Oct 24, 2017
jsteemann pushed a commit that referenced this pull request Oct 26, 2017
* Revert "Return the result of the inquiry (#3472)"

This reverts commit 1dc1a98.

* Revert "cherry picking of bug-fix/agency-restart-after-compaction-and-holes-i… (#3423)"

This reverts commit 324184d.

* State has to keep log for removeConflicts and acoording log all the way (#3249)

* Bug fix/sort out agency locks (#3306)

New locking concept in Agency. Ensure empty heartbeats can be sent, answered and processed without long locks. Adjust logging. Fix compaction bugs.

* Bug fix/agency compactor deadlock (#3335)

* Fix a deadlock between Agent thread and compactor thread.
* Improve comments in header.
* Organise clean shutdown of agency threads.

* Bug fix/agency leader timeouts (#3373)

* Send out empty heartbeats regardless of non-empty AppendEntriesRPC.
* Also improve logging:
  Note if a log in the empty heartbeat sending takes > 0.01 s.
  Clearly mark places where a leader resigns in logging.
  Log if no empty heartbeat is sent out.
* Make leader more tolerant w.r.t. incoming AppendEntriesRPC responses.
* Add debug logging for _lastAcked and challengeLeadership.
* Remove some unused code. Do not count ourselves in challengeLeadership.
* Removal of entire activation/deactivation mechanisms in agency
* TRI_microtime up to c++11
* added term to response to sendAppendEntries.

* Bug fix/agency restart after compaction and holes in log (#3413)

* State fixes holes in RAFT index range
* Avoid application of entries older than compaction index _cur and guard for unsigned overflow

* Return the result of the inquiry (#3465)

* Add a hidden AGENCY_DUMP for agency emergency recovery. (#3474)

* Port more changes from devel to 3.2.

This could not be cherry-picked, since the changes concerning the agency
were in squash commits which touch a lot of different things.

* Make members private in AgentConfiguration

* Log update of agency configuration.

* Do not deal with active in gossip phase.

* Take out some debugging output.
@fceller fceller deleted the bug-fix/agency-restart-after-compaction-and-holes-in-log-cherry-pick branch October 30, 2017 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0