8000 rework process handling by dothebart · Pull Request #3322 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

rework process handling #3322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Sep 28, 2017
Merged

rework process handling #3322

merged 16 commits into from
Sep 28, 2017

Conversation

dothebart
Copy link
Contributor
  • migrate the process handling to c++ where appropriate
  • move code definition / usage closer together
  • add function to portably detect external processes (not spawned by us) and whether we may
    send them signals
  • add portable code to send signals to processes
  • for linux match what impact a signal will have on the process we send it
  • check the status of the process we sent the signal, and return if its non-deadly or the process terminated
  • after 8 retries with 1 second sleep send a hard kill.
  • killExternal() now returns the same structure as statusExternal()
  • don't block signals on spawned processes

@fceller
Copy link
Contributor
fceller commented Sep 26, 2017 •
edited
Loading

@dothebart

[ 25%] Building CXX object lib/CMakeFiles/arango.dir/Basics/process-utils.cpp.o
/Volumes/HDD/workspace/arangodb-ci_PR-3322-PZIM4H2UEA6TDIELHNY3AL2GITXHRBGDADCWHIHJ4V6UZSWC5VCA/lib/Basics/process-utils.cpp:1253:8: error: use of undeclared identifier 'SIGPOLL'
case SIGPOLL: // Term Pollable event (Sys V).
^
/Volumes/HDD/workspace/arangodb-ci_PR-3322-PZIM4H2UEA6TDIELHNY3AL2GITXHRBGDADCWHIHJ4V6UZSWC5VCA/lib/Basics/process-utils.cpp:1272:8: error: use of undeclared identifier 'SIGSTKFLT'
case SIGSTKFLT: // -,16,- Term Stack fault on coprocessor (unused)
^
/Volumes/HDD/workspace/arangodb-ci_PR-3322-PZIM4H2UEA6TDIELHNY3AL2GITXHRBGDADCWHIHJ4V6UZSWC5VCA/lib/Basics/process-utils.cpp:1274:8: error: use of undeclared identifier 'SIGPWR'
case SIGPWR: // 29,30,19 Term Power failure (System V)
^

@fceller fceller merged commit c56e494 into devel Sep 28, 2017
neunhoef added a commit that referenced this pull request Sep 28, 2017
@neunhoef
Revert "rework process handling (#3322)"
d2b62c9 
This reverts commit c56e494.
neunhoef added a commit that referenced this pull request Sep 28, 2017
@neunhoef
Revert "Revert "rework process handling (#3322)""
3a4cf41 
This reverts commit d2b62c9.
ObiWahn added a commit that referenced this pull request Sep 29, 2017
@ObiWahn
Merge remote-tracking branch 'origin' into feature/planning-query-res…
6241287 
…ult-cache

* origin: (85 commits)
  rework process handling (#3322)
  Bug fix/agency compactor deadlock (#3335)
  restore the feature to be able to specify the CXX via the environment. (#3340)
  try to work around some assertions (#3296)
  Feature/jenkins pipeline (#3338)
  Feature/switch to 3.3 (#3336)
  Bug fix/sort out agency locks (#3306)
  Revert "shut down the second instance properly (#3332)"
  Revert "Bugfix/fix test arangod shutdown command (#3260)"
  fixed duplicate variable
  fixed links in results.html overview
  fixed jslint
  fixed missing cleanBuild check
  shut down the second instance properly (#3332)
  Feature/jenkins pipeline (#3327)
  increase default value for /proc/sys/vm/max_map_count (#3321)
  show warnings if curl work thread is blocked by error/success cbs (#3316)
  During the startup of arangod the client will fail to connect. (#3302)
  set minimum required GCC version to 5.4 (#3298)
  Feature/mmfiles hash lookup performance (#3265)
  ...
@fceller fceller deleted the bug-fix/rework_killexternal branch November 9, 2017 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
9 Ready to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dothebart @fceller
0