8000 Fix some undefined behaviour in some maintainer mode code by neunhoef · Pull Request #14891 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

Fix some undefined behaviour in some maintainer mode code #14891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy st 8000 atement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 9, 2021
Merged

Fix some undefined behaviour in some maintainer mode code #14891

merged 4 commits into from
Nov 9, 2021

Conversation

neunhoef
Copy link
Member
@neunhoef neunhoef commented Oct 8, 2021

This is a trivial bug fix for a corner case.

If in maintainer mode, or if the log topic AgencyComm is set to DEBUG
or TRACE mode, and all agents are gone, then the first element of
an empty deque is dereferenced. With STL debugging on this leads to
a crash.

@neunhoef
Fix potential undefined behaviour.
f65dabd 
This only happens when in maintainer mode or if DEBUG logging is
switched on for the AgencyComm topic, provided that all agency
endpoints are gone for some time.
@neunhoef neunhoef added this to the devel milestone Oct 8, 2021
@neunhoef neunhoef self-assigned this Oct 8, 2021
goedderz
goedderz reviewed Oct 20, 2021
View reviewed changes
jsteemann
jsteemann approved these changes Oct 21, 2021
View reviewed changes
Copy link
Contributor
@jsteemann jsteemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jsteemann jsteemann merged commit b4920a8 into devel Nov 9, 2021
@jsteemann jsteemann deleted the bug-fix/undefined-behaviour-in-debug-log-message branch November 9, 2021 18:09
jsteemann pushed a commit that referenced this pull request Mar 17, 2023
@neunhoef @jsteemann
Fix some undefined behaviour in some maintainer mode code (#14891)
ff309c1
@jsteemann jsteemann mentioned this pull request Mar 17, 2023
Merged
19 tasks
jsteemann pushed a commit that referenced this pull request Mar 17, 2023
@neunhoef @jsteemann
Fix some undefined behaviour in some maintainer mode code (#14891)
4641a47
@jsteemann jsteemann mentioned this pull request Mar 17, 2023
Merged
19 tasks
KVS85 pushed a commit that referenced this pull request Mar 17, 2023
@jsteemann @neunhoef
Fix some undefined behaviour in some maintainer mode code (#14891) (#…
722ea18 
…18372)

Co-authored-by: Max Neunhöffer <max@arangodb.com>
KVS85 pushed a commit that referenced this pull request Mar 23, 2023
@jsteemann @neunhoef
Fix some undefined behaviour in some maintainer mode code (#14891) (#…
cf8aa06 
…18371)

Co-authored-by: Max Neunhöffer <max@arangodb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goedderz goedderz goedderz left review comments

@jsteemann jsteemann jsteemann approved these changes

Assignees

@neunhoef neunhoef

Labels
None yet
Projects
None yet
Milestone
devel
Development

Successfully merging this pull request may close these issues.
3 participants
@neunhoef @jsteemann @goedderz
0