Fix some undefined behaviour in some maintainer mode code (#14891) (#18371)

jsteemann · neunhoef · web-flow · commit cf8aa06cd0e5 · 2023-03-23T16:26:07.000+03:00
Co-authored-by: Max Neunhöffer &lt;max@arangodb.com&gt;
diff --git a/arangod/Agency/AsyncAgencyComm.cpp b/arangod/Agency/AsyncAgencyComm.cpp
@@ -524,10 +524,10 @@ void AsyncAgencyCommManager::reportError(std::string const& endpoint) {
       << "reportError(" << endpoint << "), endpoints = " << _endpoints;
   if (endpoint == _endpoints.front()) {
     _endpoints.pop_front();
+    _endpoints.push_back(endpoint);
     LOG_TOPIC("aac43", DEBUG, Logger::AGENCYCOMM)
         << "Error using endpoint " << endpoint << ", switching to "
         << _endpoints.front();
-    _endpoints.push_back(endpoint);
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -524,10 +524,10 @@ void AsyncAgencyCommManager::reportError(std::string const& endpoint) {`
`524`	`524`	`<< "reportError(" << endpoint << "), endpoints = " << _endpoints;`
`525`	`525`	`if (endpoint == _endpoints.front()) {`
`526`	`526`	`_endpoints.pop_front();`
	`527`	`+ _endpoints.push_back(endpoint);`
`527`	`528`	`LOG_TOPIC("aac43", DEBUG, Logger::AGENCYCOMM)`
`528`	`529`	`<< "Error using endpoint " << endpoint << ", switching to "`
`529`	`530`	`<< _endpoints.front();`
`530`		`- _endpoints.push_back(endpoint);`
`531`	`531`	`}`
`532`	`532`	`}`
`533`	`533`