8000 Fix some undefined behaviour in some maintainer mode code (#14891) by jsteemann · Pull Request #18372 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

Fix some undefined behaviour in some maintainer mode code (#14891) #18372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

8000 Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2023
Merged

Fix some undefined behaviour in some maintainer mode code (#14891) #18372

merged 1 commit into from
Mar 17, 2023

Conversation

jsteemann
Copy link
Contributor

Scope & Purpose

Backport of #14891

This is a trivial bug fix for a corner case.

If in maintainer mode, or if the log topic AgencyComm is set to DEBUG
or TRACE mode, and all agents are gone, then the first element of
an empty deque is dereferenced. With STL debugging on this leads to
a crash.

  • 💩 Bugfix
  • 🍕 New feature
  • 🔥 Performance improvement
  • 🔨 Refactoring/simplification

Checklist

Related Information

  • Docs PR:
  • Enterprise PR:
  • GitHub issue / Jira ticket:
  • Design document:

@jsteemann jsteemann added this to the 3.8 milestone Mar 17, 2023
@cla-bot cla-bot bot added the cla-signed label Mar 17, 2023
@jsteemann jsteemann mentioned this pull request Mar 17, 2023
Merged
19 tasks
Dronplane
Dronplane approved these changes Mar 17, 2023
View reviewed changes
Copy link
Contributor
@Dronplane Dronplane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KVS85 KVS85 merged commit 722ea18 into 3.8 Mar 17, 2023
@KVS85 KVS85 deleted the bug-fix-3.8/undefined-behaviour-in-debug-log-message branch March 17, 2023 20:50
neunhoef
neunhoef reviewed Mar 19, 2023
View reviewed changes
Copy link
Member
@neunhoef neunhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neunhoef neunhoef neunhoef left review comments

@dothebart dothebart dothebart approved these changes

@Dronplane Dronplane Dronplane approved these changes

Assignees

@jsteemann jsteemann

Labels
cla-signed
Projects
None yet
Milestone
3.8
Development

Successfully merging this pull request may close these issues.
5 participants
@jsteemann @dothebart @neunhoef @Dronplane @KVS85
0