8000 Bug fix/fix msvc2019 build by Dronplane · Pull Request #11052 · arangodb/arangodb · GitHub
[go: up one dir, main page]

Skip to content

Bug fix/fix msvc2019 build #11052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8000
Merged
merged 22 commits into from
Mar 31, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
c35a353
Fix build
Dronplane Feb 3, 2020
aa2c6c1
Update VERSIONS
KVS85 Feb 3, 2020
ffc5c75
Fixed debug build&run
Dronplane Feb 6, 2020
57bd6b1
Merge branch 'bug-fix/fix-msvc2019-build' of https://github.com/arang…
Dronplane Feb 6, 2020
9f873be
Updated sort from upstream
Dronplane Feb 7, 2020
7fe80af
Merge branch 'devel' of https://github.com/arangodb/arangodb into bug…
KVS85 Feb 8, 2020
4fb0c0c
Merge branch 'devel' of github.com:arangodb/ArangoDB into bug-fix/fix…
dothebart Feb 10, 2020
1274096
Merge branch 'devel' of github.com:arangodb/arangodb into bug-fix/fix…
goedderz Feb 11, 2020
8996828
Work around MSVC STL bug
goedderz Feb 11, 2020
7693875
Merge branch 'devel' of https://github.com/arangodb/arangodb into bug…
KVS85 Feb 11, 2020
8273a79
Merge branch 'devel' of github.com:arangodb/ArangoDB into bug-fix/fix…
dothebart Feb 11, 2020
8e9b3d6
Try to use debug hack for release
Dronplane Feb 21, 2020
48aab35
Merge branch 'devel' into bug-fix/fix-msvc2019-build
Dronplane Feb 21, 2020
42be0f4
set to msvc2017
Dronplane Feb 21, 2020
912df2e
Merge branch 'devel' into bug-fix/fix-msvc2019-build
Dronplane Feb 21, 2020
357feea
Merge branch 'devel' into bug-fix/fix-msvc2019-build
Dronplane Mar 2, 2020
4b2c81a
Merge branch 'devel' of https://github.com/arangodb/arangodb into bug…
KVS85 Mar 18, 2020
fceff53
Remove MSVC workaroud
KVS85 Mar 18, 2020
84115aa
Enable MSVS 2019 usage
KVS85 Mar 18, 2020
7c87529
Merge branch 'devel' of https://github.com/arangodb/arangodb into bug…
KVS85 Mar 30, 2020
fb75804
Fixed MSVC2019 warning
Dronplane Mar 31, 2020
e0ef65a
Better fix for GraphStore
Dronplane Mar 31, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions 3rdParty/V8/v7.9.317/src/codegen/source-position.h
Original file line number Diff line number Diff line change
Expand Up @@ -146,23 +146,23 @@ class SourcePosition final {

// The two below are only used if IsExternal() is true.
using ExternalLineField = BitField64<int, 1, 20>;
#ifdef DEBUG
//#ifdef DEBUG
// looks like debug build uses more external files
// so extend bits for this field, but play safe for release builds
using ExternalFileIdField = BitField64<int, 21, 16>;
#else
using ExternalFileIdField = BitField64<int, 21, 10>;
#endif
//#else
// using ExternalFileIdField = BitField64<int, 21, 10>;
//#endif
// ScriptOffsetField is only used if IsExternal() is false.
using ScriptOffsetField = BitField64<int, 1, 30>;

// InliningId is in the high bits for better compression in
// SourcePositionTable.
#ifdef DEBUG // also shift this field for above change for ExternalFileIdField
//#ifdef DEBUG // also shift this field for above change for ExternalFileIdField
using InliningIdField = BitField64<int, 37, 16>;
#else
using InliningIdField = BitField64<int, 31, 16>;
#endif
//#else
// using InliningIdField = BitField64<int, 31, 16>;
//#endif
// Leaving the highest bit untouched to allow for signed conversion.
uint64_t value_;
};
Expand Down
2 changes: 1 addition & 1 deletion VERSIONS
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ CXX_STANDARD "17"
STARTER_REV "0.14.14"
SYNCER_REV "0.7.3"
GCC_LINUX "9.2.0"
MSVC_WINDOWS "2017"
MSVC_WINDOWS "2019"
MACOS_MIN "10.14"
OPENSSL_LINUX "1.1.1d"
OPENSSL_MACOS "1.1.1d"
Expand Down
2 changes: 1 addition & 1 deletion arangod/Aql/AqlItemMatrix.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ ShadowAqlItemRow AqlItemMatrix::popShadowRow() {
TRI_ASSERT(blockPtr->size() >= _startIndexInFirstBlock);
_size = blockPtr->size() - _startIndexInFirstBlock;
}
// Remove all but the last
// Remove all but the last block
_blocks.erase(_blocks.begin(), _blocks.end() - 1);
TRI_ASSERT(_blocks.size() == 1);
return shadowRow;
Expand Down
8 changes: 4 additions & 4 deletions arangod/Pregel/GraphStore.h
Original file line number Diff line number Diff line change
Expand Up @@ -98,11 +98,11 @@ class GraphStore final {
void _storeVertices(std::vector<ShardID> const& globalShards,
RangeIterator<Vertex<V,E>>& it);

size_t vertexSegmentSize () const {
return std::ceil<size_t>( 64 * 1024 * 1024 / sizeof(Vertex<V,E>));
constexpr size_t vertexSegmentSize () const {
return 64 * 1024 * 1024 / sizeof(Vertex<V,E>);
}
size_t edgeSegmentSize() const {
return std::ceil<size_t>( 64 * 1024 * 1024 / sizeof(Edge<E>));
constexpr size_t edgeSegmentSize() const {
return 64 * 1024 * 1024 / sizeof(Edge<E>);
}

private:
Expand Down
0