Remove MSVC workaroud

arangodb · KVS85 · Mar 31, 2020 · Feb 3, 2020 · Feb 3, 2020 · Feb 6, 2020
commit fceff5380a80809be94a52d97a9d8604ba894ba3
diff --git a/arangod/Aql/AqlItemMatrix.cpp b/arangod/Aql/AqlItemMatrix.cpp
@@ -201,15 +201,7 @@ ShadowAqlItemRow AqlItemMatrix::popShadowRow() {
     _size = blockPtr->size() - lastSize - 1;
   }
   // Remove all but the last block
-  auto const first = _blocks.begin();
-  auto const last = _blocks.end() - 1;
-  // This check should be unnecessary, but is here to work around the bug
-  // https://developercommunity.visualstudio.com/content/problem/776568/vc-move-assigns-the-vector-to-itself-if-erase-is-c.html
-  // where vector::erase of the STL in MSVC 2019 calls self-move-assignments on
-  // every element from first to end() in the vector, if first == last.
-  if (first != last) {
-    _blocks.erase(first, last);
-  }
+  _blocks.erase(_blocks.begin(), _blocks.end() - 1);
   TRI_ASSERT(_blocks.size() == 1);
   return shadowRow;
 }