8000 Bug fix/fix msvc2019 build by Dronplane · Pull Request #11052 · arangodb/arangodb · GitHub
[go: up one dir, main page]

Skip to content

Bug fix/fix msvc2019 build #11052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8000
Merged
merged 22 commits into from
Mar 31, 2020
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
c35a353
Fix build
Dronplane Feb 3, 2020
aa2c6c1
Update VERSIONS
KVS85 Feb 3, 2020
ffc5c75
Fixed debug build&run
Dronplane Feb 6, 2020
57bd6b1
Merge branch 'bug-fix/fix-msvc2019-build' of https://github.com/arang…
Dronplane Feb 6, 2020
9f873be
Updated sort from upstream
Dronplane Feb 7, 2020
7fe80af
Merge branch 'devel' of https://github.com/arangodb/arangodb into bug…
KVS85 Feb 8, 2020
4fb0c0c
Merge branch 'devel' of github.com:arangodb/ArangoDB into bug-fix/fix…
dothebart Feb 10, 2020
1274096
Merge branch 'devel' of github.com:arangodb/arangodb into bug-fix/fix…
goedderz Feb 11, 2020
8996828
Work around MSVC STL bug
goedderz Feb 11, 2020
7693875
Merge branch 'devel' of https://github.com/arangodb/arangodb into bug…
KVS85 Feb 11, 2020
8273a79
Merge branch 'devel' of github.com:arangodb/ArangoDB into bug-fix/fix…
dothebart Feb 11, 2020
8e9b3d6
Try to use debug hack for release
Dronplane Feb 21, 2020
48aab35
Merge branch 'devel' into bug-fix/fix-msvc2019-build
Dronplane Feb 21, 2020
42be0f4
set to msvc2017
Dronplane Feb 21, 2020
912df2e
Merge branch 'devel' into bug-fix/fix-msvc2019-build
Dronplane Feb 21, 2020
357feea
Merge branch 'devel' into bug-fix/fix-msvc2019-build
Dronplane Mar 2, 2020
4b2c81a
Merge branch 'devel' of https://github.com/arangodb/arangodb into bug…
KVS85 Mar 18, 2020
fceff53
Remove MSVC workaroud
KVS85 Mar 18, 2020
84115aa
Enable MSVS 2019 usage
KVS85 Mar 18, 2020
7c87529
Merge branch 'devel' of https://github.com/arangodb/arangodb into bug…
KVS85 Mar 30, 2020
fb75804
Fixed MSVC2019 warning
Dronplane Mar 31, 2020
e0ef65a
Better fix for GraphStore
Dronplane Mar 31, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix build
  • Loading branch information
Dronplane committed Feb 3, 2020
commit c35a353e0bb92f9ce632f3317a883947d04cf98c
2 changes: 1 addition & 1 deletion 3rdParty/fuerte/src/H2Connection.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -588,7 +588,7 @@ void H2Connection<T>::queueHttp2Requests() {
uint8_t* buf, size_t length, uint32_t* data_flags,
nghttp2_data_source* source,
void* user_data) -> ssize_t {
auto strm = static_cast<H2Connection<T>::Stream*>(source->ptr);
auto strm = static_cast<typename H2Connection<T>::Stream*>(source->ptr);

auto payload = strm->request->payload();

Expand Down
1 change: 1 addition & 0 deletions 3rdParty/fuerte/src/types.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
#include <fuerte/types.h>

#include <algorithm>
#include <stdexcept>

namespace arangodb { namespace fuerte { inline namespace v1 {

Expand Down
11 changes: 8 additions & 3 deletions 3rdParty/iresearch/core/utils/arena_allocator.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -148,9 +148,7 @@ class arena_allocator {

template<typename T1, typename U, typename A1, typename A2>
friend bool operator==(const arena_allocator<T1, A1>& lhs,
const arena_allocator<U, A2>& rhs) noexcept {
return std::is_same<A1, A2>::value && lhs.arena_ == rhs.arena_;
}
const arena_allocator<U, A2>& rhs) noexcept;

template <typename U, typename A>
friend class arena_allocator;
Expand All @@ -167,6 +165,13 @@ inline bool operator!=(const arena_allocator<T, A1>& lhs,
return !(lhs == rhs);
}

template<typename T1, typename U, typename A1, typename A2>
inline bool operator==(const arena_allocator<T1, A1>& lhs,
const arena_allocator<U, A2>& rhs) noexcept {
return std::is_same<A1, A2>::value &&
lhs.arena_ == reinterpret_cast<const void*>(rhs.arena_);
}

template<typename T, size_t N>
using arena = memory_arena<N*sizeof(T), alignof(T)>;

Expand Down
1 change: 1 addition & 0 deletions lib/ProgramOptions/Parameters.h
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
#include <numeric>
#include <type_traits>
#include <unordered_set>
#include <stdexcept>

namespace arangodb {
namespace options {
Expand Down
1 change: 1 addition & 0 deletions lib/Rest/Version.h
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
#define ARANGODB_REST_VERSION_H 1

#include <map>
#include <string>

#include "Basics/operating-system.h"

Expand Down
6 changes: 0 additions & 6 deletions tests/IResearch/ExpressionFilter-test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -200,12 +200,6 @@ struct custom_sort : public irs::sort {
score_cast(score) = irs::doc_limits::invalid();
}

virtual void add(irs::byte_type* dst, irs::byte_type const* src) const override {
if (sort_.scorer_add) {
sort_.scorer_add(score_cast(dst), score_cast(src));
}
}

virtual void merge(irs::byte_type* dst, const irs::byte_type** src_start,
const size_t size, size_t offset) const override {
auto& casted_dst = score_cast(dst + offset);
Expand Down
1 change: 0 additions & 1 deletion tests/IResearch/IResearchView-test.cpp
628C
Original file line numberDiff line number Diff line change
Expand Up @@ -103,7 +103,6 @@ struct DocIdScorer: public irs::sort {
virtual sort::prepared::ptr prepare() const override { PTR_NAMED(Prepared, ptr); return ptr; }

struct Prepared: public irs::sort::prepared_base<uint64_t, void> {
virtual void add(irs::byte_type* dst, const irs::byte_type* src) const override { score_cast(dst) = score_cast(src); }
virtual void merge(irs::byte_type* dst, const irs::byte_type** src_start,
const size_t size, size_t offset) const override {
auto& casted_dst = score_cast(dst + offset);
Expand Down
8 changes: 0 additions & 8 deletions tests/IResearch/common.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -155,10 +155,6 @@ struct BoostScorer : public irs::sort {

Prepared() = default;

virtual void add(irs::byte_type* dst, irs::byte_type const* src) const override {
score_cast(dst) += score_cast(src);
}

virtual void merge(irs::byte_type* dst, const irs::byte_type** src_start,
const size_t size, size_t offset) const override {
auto& casted_dst = score_cast(dst + offset);
Expand Down Expand Up @@ -239,10 +235,6 @@ struct CustomScorer : public irs::sort {

Prepared(float_t i) : i(i) {}

virtual void add(irs::byte_type* dst, const irs::byte_type* src) const override {
score_cast(dst) += score_cast(src);
}

virtual void merge(irs::byte_type* dst, const irs::byte_type** src_start,
const size_t size, size_t offset) const override {
auto& casted_dst = score_cast(dst + offset);
Expand Down
0