8000 Update dependencies by tagliala · Pull Request #8370 · activeadmin/activeadmin · GitHub
[go: up one dir, main page]
Skip to content

Update dependencies #8370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 9, 2024
Merged

Update dependencies #8370

merged 3 commits into from
Jun 9, 2024

Conversation

tagliala
Copy link
Contributor
@tagliala tagliala commented Jun 9, 2024 •
edited
Loading

Also:

  • Fix new RuboCop offenses
  • Use the latest rubygems to allow specs against Ruby 3.0

tagliala
tagliala commented Jun 9, 2024
View reviewed changes
@codecov Codecov
Copy link
codecov bot commented Jun 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.10%. Comparing base (2a88ad5) to head (935e567).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #8370   +/-   ##
=======================================
  Coverage   99.10%   99.10%           
=======================================
  Files         140      140           
  Lines        4018     4018           
=======================================
  Hits         3982     3982           
  Misses         36       36

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tagliala tagliala mentioned this pull request Jun 9, 2024
Merged
3 tasks
tagliala added 3 commits June 9, 2024 19:31
@tagliala
Update dependencies
a41330d
@tagliala
Autofix new safe RuboCop offenses
616c607
@tagliala
Always use the latest rubygems
935e567 
Allows to run CI against Ruby 3.0:

```
ffi-1.17.0-x86_64-linux requires rubygems version >= 3.3.22, which is
incompatible with the current version, 3.2.33
```
@tagliala tagliala force-pushed the chore/update-dependencies branch from c33d28a to 935e567 Compare June 9, 2024 17:31
javierjulio
javierjulio approved these changes Jun 9, 2024
View reviewed changes
Copy link
Member
@javierjulio javierjulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@javierjulio javierjulio merged commit b2e82f2 into activeadmin:master Jun 9, 2024
21 checks passed
@tagliala tagliala deleted the chore/update-dependencies branch June 9, 2024 17:38
tagliala added a commit to tagliala/activeadmin that referenced this pull request Jul 28, 2024
@tagliala
Update dependencies
82eb36a 
Also backport activeadmin#8344 and use latest rubygems from activeadmin#8370
@tagliala tagliala mentioned this pull request Jul 28, 2024
Merged
tagliala added a commit to tagliala/activeadmin that referenced this pull request Jul 28, 2024
@tagliala
Update dependencies
838dc54 
Also:
- Backport activeadmin#8344
- Use latest rubygems (partial backport of activeadmin#8370)
- Backport activeadmin#8372
tagliala added a commit that referenced this pull request Jul 28, 2024
@tagliala
3.x: Update dependencies (#8408)
04e4dca 
Update dependencies

Also:
- Backport #8344
- Use latest rubygems (partial backport of #8370)
- Backport #8372
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javierjulio javierjulio javierjulio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tagliala @javierjulio
0