-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Test against Rails 7.2 #8371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test against Rails 7.2 #8371
Conversation
9818b02
to
49d854a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8371 +/- ##
=======================================
Coverage 99.10% 99.10%
=======================================
Files 140 140
Lines 4029 4029
=======================================
Hits 3993 3993
Misses 36 36 ☔ View full report in Codecov by Sentry. |
49d854a
to
8b7ada5
Compare
8b7ada5
to
2209995
Compare
e0fce07
to
23d5113
Compare
All specs pass and I do not see warnings |
@tagliala changes look great, thank you. Did you want to have this reviewed and merged as is or prefer to wait for final release? |
Maybe it is better to wait for the final release or an rc at least |
0aa48e4
to
303bfc3
Compare
303bfc3
to
c13a163
Compare
Tested against RC1 |
81d4032
to
f8d0def
Compare
f8d0def
to
dcf81e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Rebase after:
Close #8367