8000 Test against Rails 7.2 by tagliala · Pull Request #8371 · activeadmin/activeadmin · GitHub
[go: up one dir, main page]
Skip to content

Test against Rails 7.2 #8371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2024
Merged

Test against Rails 7.2 #8371

merged 1 commit into from
Aug 11, 2024
+559 −80

Conversation

tagliala
Copy link
Contributor
@tagliala tagliala commented Jun 9, 2024 •
edited
Loading

@tagliala tagliala force-pushed the feature/prepare-for-rails-72 branch 3 times, most recently from 9818b02 to 49d854a Compare June 9, 2024 17:31
@codecov Codecov
Copy link
codecov bot commented Jun 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.10%. Comparing base (f2851c6) to head (dcf81e2).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #8371   +/-   ##
=======================================
  Coverage   99.10%   99.10%           
=======================================
  Files         140      140           
  Lines        4029     4029           
=======================================
  Hits         3993     3993           
  Misses         36       36

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tagliala tagliala force-pushed the feature/prepare-for-rails-72 branch from 49d854a to 8b7ada5 Compare June 9, 2024 17:43
@tagliala tagliala force-pushed the feature/prepare-for-rails-72 branch from 8b7ada5 to 2209995 Compare July 1, 2024 09:51
@tagliala tagliala force-pushed the feature/prepare-for-rails-72 branch 2 times, most recently from e0fce07 to 23d5113 Compare July 14, 2024 20:20
@tagliala
Copy link
Contributor Author

All specs pass and I do not see warnings

@tagliala tagliala changed the title Prepare for Rails 7.2 Prepare for Rails 7.2 (beta3 ✅) Jul 14, 2024
@javierjulio
Copy link
Member

@tagliala changes look great, thank you. Did you want to have this reviewed and merged as is or prefer to wait for final release?

@tagliala
Copy link
Contributor Author

Did you want to have this reviewed and merged as is or prefer to wait for final release?

Maybe it is better to wait for the final release or an rc at least

@tagliala tagliala force-pushed the feature/prepare-for-rails-72 branch 3 times, most recently from 0aa48e4 to 303bfc3 Compare July 28, 2024 16:33
@tagliala tagliala force-pushed the feature/prepare-for-rails-72 branch from 303bfc3 to c13a163 Compare August 9, 2024 10:34
@tagliala tagliala changed the title Prepare for Rails 7.2 (beta3 ✅) Prepare for Rails 7.2 (rc1 ✅) Aug 9, 2024
@tagliala
Copy link
Contributor Author
tagliala commented Aug 9, 2024

Tested against RC1

@tagliala tagliala force-pushed the feature/prepare-for-rails-72 branch 2 times, most recently from 81d4032 to f8d0def Compare August 10, 2024 07:47
@tagliala tagliala force-pushed the feature/prepare-for-rails-72 branch from f8d0def to dcf81e2 Compare August 10, 2024 07:48
@tagliala tagliala changed the title Prepare for Rails 7.2 (rc1 ✅) Test against Rails 7.2 Aug 10, 2024
@tagliala tagliala marked this pull request as ready for review August 10, 2024 07:48
@tagliala tagliala marked this pull request as draft August 10, 2024 09:19
@tagliala tagliala marked this pull request as ready for review August 10, 2024 14:28
@tagliala tagliala requested a review from javierjulio August 10, 2024 14:28
javierjulio
javierjulio approved these changes Aug 10, 2024
View reviewed changes
Copy link
Member
@javierjulio javierjulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tagliala tagliala merged commit 3c6d22f into activeadmin:master Aug 11, 2024
24 checks passed
@tagliala tagliala deleted the feature/prepare-for-rails-72 branch August 11, 2024 08:00
@mgrunberg mgrunberg mentioned this pull request Aug 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javierjulio javierjulio javierjulio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rails 7.2: prepare CI for testing
2 participants
@tagliala @javierjulio
0