Make lockfile platforms easier to maintain #8344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8344 +/- ##
=======================================
Coverage 99.10% 99.10%
=======================================
Files 140 140
Lines 4018 4018
=======================================
Hits 3982 3982
Misses 36 36 ☔ View full report in Codecov by Sentry. |
javierjulio
reviewed
May 28, 2024
|
Yeah, I should've added a bit more context! So these platform values ultimately come from Ruby. For example, When Bundler is run, it uses the value of the local platform, and finds the optimal resolution for the local platform. For example, if you're on The specific number in this case is supposed to track the specific macOS version. However, in practice, gem authors don't release macOS version specific variants of their gems, since the platforms are the same in practice. So, there's no Recent versions of Bundler will "optimize" this, and as long as no variants specific to the macOS version exist, it will lock only arch + OS, but not the specific macOS version. So, these should not get added in the future again as long as we use a recent enough version of Bundler. I'll add the same changes to the other gemfiles, good idea! |
395414a to
86be771
Compare
Oh great, just tested because my dev environment was adding platforms and it does not happen on this branch |
86be771 to
8722101
Compare
|
Thanks both! |
tagliala
added a commit
to tagliala/inherited_resources
that referenced
this pull request
Jun 1, 2024
This should work equally well and has less churn when maintainers upgrade their OS or switch platforms. Recent versions of Bundler will "optimize" this, and as long as no variants specific to the macOS version exist, it will lock only arch + OS, but not the specific macOS version. These should not get added in the future again as long as we use a recent enough version of Bundler, and for this reason locked Bundler has been bumped to 2.5.11 Ref: activeadmin/activeadmin#8344
tagliala
added a commit
to tagliala/inherited_resources
that referenced
this pull request
Jun 1, 2024
This should work equally well and has less churn when maintainers upgrade their OS or switch platforms. Recent versions of Bundler will "optimize" this, and as long as no variants specific to the macOS version exist, it will lock only arch + OS, but not the specific macOS version. These should not get added in the future again as long as we use a recent enough version of Bundler, and for this reason locked Bundler has been bumped to 2.5.11 Ref: activeadmin/activeadmin#8344
javierjulio
pushed a commit
to activeadmin/inherited_resources
that referenced
this pull request
Jun 1, 2024
This should work equally well and has less churn when maintainers upgrade their OS or switch platforms. Recent versions of Bundler will "optimize" this, and as long as no variants specific to the macOS version exist, it will lock only arch + OS, but not the specific macOS version. These should not get added in the future again as long as we use a recent enough version of Bundler, and for this reason locked Bundler has been bumped to 2.5.11 Ref: activeadmin/activeadmin#8344
tagliala
added a commit
to tagliala/activeadmin
that referenced
this pull request
Jul 28, 2024
Also backport activeadmin#8344
tagliala
added a commit
to tagliala/activeadmin
that referenced
this pull request
Jul 28, 2024
Also backport activeadmin#8344 and use latest rubygems from activeadmin#8370
tagliala
added a commit
to tagliala/activeadmin
that referenced
this pull request
Jul 28, 2024
Also: - Backport activeadmin#8344 - Use latest rubygems (partial backport of activeadmin#8370) - Backport activeadmin#8372
tagliala
added a commit
that referenced
this pull request
Jul 28, 2024
tagliala
added a commit
to tagliala/active_storage_validations
that referenced
this pull request
Oct 11, 2024
- Test against Rails 7.2 - Test against Ruby 3.3 - Make lockfile platforms easier to maintain (ref: activeadmin/activeadmin#8344) - Update bundles
tagliala
added a commit
to tagliala/active_storage_validations
that referenced
this pull request
Oct 11, 2024
- Test against Rails 7.2 - Test against Ruby 3.3 - Make lockfile platforms easier to maintain (ref: activeadmin/activeadmin#8344) - Update bundles by using the minimum supported ruby version
tagliala
added a commit
to tagliala/active_storage_validations
that referenced
this pull request
Oct 11, 2024
- Test against Rails 7.2 - Test against Ruby 3.3 - Make lockfile platforms easier to maintain (ref: activeadmin/activeadmin#8344) - Update bundles by using the minimum supported ruby version
tagliala
added a commit
to tagliala/active_storage_validations
that referenced
this pull request
Oct 11, 2024
- Test against Rails 7.2 - Test against Ruby 3.3 - Make lockfile platforms easier to maintain (ref: activeadmin/activeadmin#8344) - Update bundles by using the minimum supported ruby version
tagliala
added a commit
to tagliala/active_storage_validations
that referenced
this pull request
Oct 11, 2024
- Test against Rails 7.2 - Test against Ruby 3.3 - Make lockfile platforms easier to maintain (ref: activeadmin/activeadmin#8344) - Update bundles by using the minimum supported ruby version
tagliala
added a commit
to tagliala/active_storage_validations
that referenced
this pull request
Oct 11, 2024
- Test against Rails 7.2 - Test against Ruby 3.3 - Make lockfile platforms easier to maintain (ref: activeadmin/activeadmin#8344) - Update bundles by using the minimum supported ruby version
tagliala
added a commit
to tagliala/active_storage_validations
that referenced
this pull request
Oct 11, 2024
- Test against Rails 7.2 - Test against Ruby 3.3 - Make lockfile platforms easier to maintain (ref: activeadmin/activeadmin#8344) - Update bundles by using the minimum supported ruby version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should work equally well and has less churn when maintainers upgrade their OS or switch platforms.