8000 Update Python libraries and tests from CPython 3.12 · Issue #5104 · RustPython/RustPython · GitHub
[go: up one dir, main page]
Skip to content

Update Python libraries and tests from CPython 3.12 #5104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
youknowone opened this issue Oct 23, 2023 · 11 comments
Closed

Update Python libraries and tests from CPython 3.12 #5104

youknowone opened this issue Oct 23, 2023 · 11 comments
Labels
A-stdlib C-compat A discrepancy between RustPython and CPython C-enhancement New feature or request good first issue Good for newcomers

Comments

@youknowone
Copy link
Member
youknowone commented Oct 23, 2023 •
edited
Loading

Though it will be sometimes blocked by rust side issues, don't worry!
Please just create PR about the broken test and and create issues related to the new bugs.

If you are new to updating cpython libraries, this guide will be useful:
https://github.com/RustPython/RustPython/wiki/How-to-update-test-files

When updating module Lib/X, please don't forget to also update Lib/test/test_X

A few libraries doesn't need to be updated because CPython also kept it same as previous version. In that case, please leave a comment to let us mark it as done. Thank you!

Tips

  • To get specific version of CPython source code, e.g. try git checkout v3.12.0 from CPython repository.
  • Please check Update libraries and tests from CPython 3.10.6 #4064 for example. Not the entire changes but the each commits. One of the middle size example is 17e12de . Sometimes it can be really simple like 9571a68
  • Please create one PR for one library+test pair whenever possible. Once you stuck by dependencies, go to one of the dependency first and finish it before restarting the stuck one unless they become simpler to be updated at the same time. Normally adding more libraries make passing tests (a lot) harder.
  • To run tests, try cargo run --features ssl -- -m test -v <test_name>. e.g. If you changed test_unicode.py, cargo run --features ssl -- -m test -v test_unicode
    • If it runs too slow, try to add --release like cargo run --release --features ssl -- -m test -v test_unicode

List of libraries

List of tests without python libraries

Not yet added libraries

These libraris are not added yet. Pure python one will be possible while others are not.
@youknowone youknowone mentioned this issue Oct 23, 2023
Closed
@youknowone youknowone pinned this issue Oct 23, 2023
@youknowone youknowone added C-enhancement New feature or request good first issue Good for newcomers C-compat A discrepancy between RustPython and CPython A-stdlib labels Oct 23, 2023
@cygao90 cygao90 mentioned this issue Nov 22, 2023
Merged
@NakanoMiku39 NakanoMiku39 mentioned this issue Nov 23, 2023
Merged
@NakanoMiku39 NakanoMiku39 mentioned this issue Nov 30, 2023
Merged
@NakanoMiku39 NakanoMiku39 mentioned this issue Dec 23, 2023
Merged
This was referenced Feb 18, 2024
Merged
Merged
@Blues-star
Copy link
Contributor
Blues-star commented Feb 19, 2024 •
edited
Loading

chunk.py doesn't need to be updated

This was referenced Feb 20, 2024
Merged
Merged
@dchiquito dchiquito mentioned this issue Feb 24, 2024
Merged
@youknowone youknowone mentioned this issue Mar 8, 2024
Merged
@Eclips4
Copy link
Contributor
Eclips4 commented Mar 8, 2024 •
edited
Loading

Modules:

  • heapq.py doesn't need to be updated
  • hmac.py doesn't need to be updated

Tests:

@Eclips4
Copy link
Contributor
Eclips4 commented Mar 13, 2024 •
edited
Loading

cgi.py doesn't need to be updated
test_cgi.py also doesn't need to be updated
Same for cmd.py and test_cmd.py

@youknowone youknowone mentioned this issue Mar 28, 2024
Merged
@jkauerl
Copy link
jkauerl commented Jun 19, 2024

Hi, from this list, what is a good library and/or test to implement as a good first issue?

@youknowone
Copy link
Member Author

@jkauerl Hi. In high chance, unpopular libraries are technically easy to update. But those are not that much fun. I'd like to encourage to try libraries you are already familiar with. Then understanding errors and bugs will be easier and enjoyable.

@kingiler kingiler mentioned this issue Jun 20, 2024
Closed
This was referenced Nov 10, 2024
Merged
Merged
This was referenced Nov 26, 2024
Closed
Merged
@arihant2math
Copy link
Collaborator

test/test_zlib.py has been updated to 3.12 as per #5476

@arihant2math
Copy link
Collaborator
arihant2math commented Jan 17, 2025 •
edited
Loading

_compression.py has either already been updated or has not changed. The same applies to _markupbase.py, also the same for this.py

@arihant2math
Copy link
Collaborator

Also the same for test/test_int_literal.py

@hbina hbina mentioned this issue Feb 10, 2025
Merged
@hbina
Copy link
Contributor
hbina commented Feb 10, 2025

Doesn't look like test_binop.py changed.

@arihant2math
Copy link
Collaborator
arihant2math commented Feb 16, 2025 •
edited
Loading

This should probably be re-targeted to 3.13

@youknowone youknowone unpinned this issue Feb 20, 2025
@youknowone
Copy link
Member Author

Thanks to everyone who participated in the 3.12 library support marathon for a year!
Based on this marathon, we are moving forward with Python 3.13 support in #5529

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-stdlib C-compat A discrepancy between RustPython and CPython C-enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@youknowone @hbina @Blues-star @arihant2math @Eclips4 @jkauerl
0