8000 Update Logging to 3.12.7 by arihant2math · Pull Request #5478 · RustPython/RustPython · GitHub
[go: up one dir, main page]
Skip to content

Update Logging to 3.12.7 #5478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 17, 2025
Merged

Update Logging to 3.12.7 #5478

merged 8 commits into from
Jan 17, 2025

Conversation

arihant2math
Copy link
Collaborator

Turns out logging tests were not being tested, this pr adds them too. This also adds smtplib because that is needed for logging tests

@arihant2math arihant2math marked this pull request as ready for review January 15, 2025 20:15
@arihant2math
Copy link
Collaborator Author

All tests pass

/cc @youknowone

@youknowone youknowone mentioned this pull request Jan 17, 2025
Closed
youknowone
youknowone requested changes Jan 17, 2025
View reviewed changes
Copy link
Member
@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! Everything in the code looks good.
Is this also from CPython 3.12.6? Leaving a specific import version on PR title is helpful to track the current RustPython library versions when we update it to next version.

@arihant2math
Copy link
Collaborator Author

Thanks, it's 3.12.7 this time.

@arihant2math arihant2math changed the title Update Logging to 3.12 Update Logging to 3.12.7 Jan 17, 2025
youknowone
youknowone approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member
@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@youknowone youknowone merged commit 16d8bab into RustPython:main Jan 17, 2025
11 checks passed
@arihant2math arihant2math deleted the logging-312 branch January 17, 2025 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowone youknowone youknowone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arihant2math @youknowone
0