Update _collections_abc.py and test_collections.py to 3.12.2#5180
Merged
youknowone merged 7 commits intoRustPython:mainfrom Feb 26, 2024
Merged
Update _collections_abc.py and test_collections.py to 3.12.2#5180youknowone merged 7 commits intoRustPython:mainfrom
_collections_abc.py and test_collections.py to 3.12.2#5180youknowone merged 7 commits intoRustPython:mainfrom
Conversation
This test will not work until the `__buffer__` and `__release_buffer__` methods are implemented on the appropriate builtin types, which is outside the current scope.
This should be resolved when `typing.py` and `test_typing.py` are updated to 3.12.
I missed that the typing test I disabled was on a base test class. Moving the expected failure to the subclass allows the passing test to pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
_collections_abc.pyandtest_collections.pyto 3.12.2test_Bufferis disabled pending #5179This should check off
_collections_abc.pyandtest/test_ordered_dict.py. from #5104. I'm unsure what else would be required to check offcollections.