8000 Tracking issue of os.utime regression · Issue #4053 · RustPython/RustPython · GitHub
[go: up one dir, main page]
Skip to content

Tracking issue of os.utime regression #4053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
youknowone opened this issue Aug 13, 2022 · 2 comments
Open

Tracking issue of os.utime regression #4053

youknowone opened this issue Aug 13, 2022 · 2 comments
Labels
C-bug Something isn't working

Comments

@youknowone
Copy link
Member

std::time::Duration::from_secs_f64 behavior is changed in Rust 1.63.

related python test:

  • test_os::test_utime_by_indexed
  • test_os::test_utime_by_times

test command:

  • cargo +stable run Lib/test/test_os.py -k utime -v
  • cargo +1.62.1 run Lib/test/test_os.py -k utime -v

Rust issue including minimal reproducible code

To-do

We will stay on 1.62.1 until checking if it is a rust bug or intended change.

Once it is resolved:
@youknowone youknowone added the C-bug Something isn't working label Aug 13, 2022
@youknowone
Copy link
Member Author

In CPython, _PyTime_DoubleToDenominator provides rounding option. floor option is passed for this path.

@youknowone youknowone mentioned this issue Aug 14, 2022
Merged
@youknowone
Copy link
Member Author

It was an intended behavior change from Rust. we need to implement rounding option like cpython.

@youknowone youknowone mentioned this issue Feb 25, 2023
Closed
@youknowone youknowone mentioned this issue Oct 23, 2023
Closed
@youknowone youknowone mentioned this issue Feb 20, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@youknowone
0