8000 Store return code as an attribute in ToolsHandler context manager. by rwalton-arm · Pull Request #22 · ARMmbed/mbed-tools-lib · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Jul 27, 2020. It is now read-only.

Store return code as an attribute in ToolsHandler context manager. #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Store return code as an attribute in ToolsHandler context manager. #22

wants to merge 1 commit into from

Conversation

rwalton-arm
Copy link
Contributor

Description

This is needed so we can exit with the correct code in the mbed-tools cli.

This is a workaround as python eats the output of __exit__ making it unavailable in the execution context.

Test Coverage

  • This change is covered by existing or additional automated tests.
  • Manual testing has been performed (and evidence provided) as automated testing was not feasible.
  • Additional tests are not required for this change (e.g. documentation update).

@rwalton-arm rwalton-arm requested a review from madchutney May 7, 2020 10:53
@rwalton-arm rwalton-arm mentioned this pull request May 7, 2020
Closed
3 tasks
@codecov
Copy link
codecov bot commented May 7, 2020 •
edited
Loading

Codecov Report

Merging #22 into master will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
+ Coverage   98.24%   98.36%   +0.11%     
==========================================
  Files           5        5              
  Lines          57       61       +4     
==========================================
+ Hits           56       60       +4     
  Misses          1        1
Impacted Files Coverage Δ
mbed_tools_lib/logging.py 100.00% <100.00%> (ø)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@madchutney madchutney Awaiting requested review from madchutney

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rwalton-arm
0