8000 Store return code as an attribute in ToolsHandler context manager. by rwalton-arm · Pull Request #22 · ARMmbed/mbed-tools-lib · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Jul 27, 2020. It is now read-only.

Store return code as an attribute in ToolsHandler context manager. #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Store return code as an attribute in ToolsHandler context manager. #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions mbed_tools_lib/logging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ def __init__(self, logger: logging.Logger, traceback: bool = False):
"""Keep track of the logger to use and whether or not a traceback should be generated."""
self._logger = logger
self._traceback = traceback
self.return_code = 0

def __enter__(self) -> "MbedToolsHandler":
"""Return the Context Manager."""
Expand All @@ -51,8 +52,12 @@ def __exit__(
error_msg = _exception_message(cast(BaseException, exc_value), logging.root.level, self._traceback)
self._logger.error(error_msg, exc_info=self._traceback)
# Do not propagate exceptions derived from ToolsError
self.return_code = 1
return True

if not exc_type:
self.return_code = 0

# Propagate all other exceptions
return False

Expand Down
1 change: 1 addition & 0 deletions news/20200507.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Store return code as an attribute in ToolsHandler context manager.
0