8000 Ensure the correct exit code is returned when a ToolsError is raised by rwalton-arm · Pull Request #23 · ARMmbed/mbed-tools · GitHub
[go: up one dir, main page]
Skip to content

Ensure the correct exit code is returned when a ToolsError is raised #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Ensure the correct exit code is returned when a ToolsError is raised #23

wants to merge 2 commits into from

Conversation

rwalton-arm
Copy link
Contributor
@rwalton-arm rwalton-arm commented May 7, 2020 •
edited
Loading

Description

When ToolsErrors were raised the cli returned an exit code of 0.

This is dependent on ARMmbed/mbed-tools-lib#22

Test Coverage

  • This change is covered by existing or additional automated tests.
  • Manual testing has been performed (and evidence provided) as automated testing was not feasible.
  • Additional tests are not required for this change (e.g. documentation update).

@rwalton-arm rwalton-arm requested a review from madchutney May 7, 2020 10:53
@codecov
Copy link
codecov bot commented May 7, 2020 •
edited
Loading

Codecov Report

Merging #23 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #23   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines           63        65    +2     
=========================================
+ Hits            63        65    +2
Impacted Files Coverage Δ
mbed_tools/_version.py 100.00% <100.00%> (ø)
mbed_tools/cli.py 100.00% <100.00%> (ø)

@rwalton-arm rwalton-arm force-pushed the rw-fix-return-codes branch from 3927fb8 to 15da147 Compare June 30, 2020 21:29
@rwalton-arm rwalton-arm deleted the rw-fix-return-codes branch July 29, 2020 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madchutney madchutney Awaiting requested review from madchutney

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rwalton-arm
0