Change #1080376 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] RevisionReviewForm: Avoid double-counting "revertedEdits"

https://gerrit.wikimedia.org/r/1080376

This should be fixed on all wikis now.

Mentioned in SAL (#wikimedia-operations) [2024-11-25T14:57:19Z] <lucaswerkmeister-wmde@deploy2002> Finished scap sync-world: Backport for [[gerrit:1097381|Pass context to 'revreview-pending-basic' on history page (T380519)]], [[gerrit:1097382|Use Contexts for Message objects in review dialog (tooltip) (T380519)]] (duration: 15m 35s)

Mentioned in SAL (#wikimedia-operations) [2024-11-25T14:48:17Z] <lucaswerkmeister-wmde@deploy2002> lucaswerkmeister-wmde, matmarex: Backport for [[gerrit:1097381|Pass context to 'revreview-pending-basic' on history page (T380519)]], [[gerrit:1097382|Use Contexts for Message objects in review dialog (tooltip) (T380519)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-11-25T14:41:45Z] <lucaswerkmeister-wmde@deploy2002> Started scap sync-world: Backport for [[gerrit:1097381|Pass context to 'revreview-pending-basic' on history page (T380519)]], [[gerrit:1097382|Use Contexts for Message objects in review dialog (tooltip) (T380519)]]

Change #1097382 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@wmf/1.44.0-wmf.4] Use Contexts for Message objects in review dialog (tooltip)

https://gerrit.wikimedia.org/r/1097382

Change #1097381 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@wmf/1.44.0-wmf.4] Pass context to 'revreview-pending-basic' on history page

https://gerrit.wikimedia.org/r/1097381

Change #1097382 had a related patch set uploaded (by Bartosz Dziewoński; author: Wargo):

[mediawiki/extensions/FlaggedRevs@wmf/1.44.0-wmf.4] Use Contexts for Message objects in review dialog (tooltip)

https://gerrit.wikimedia.org/r/1097382

Change #1097381 had a related patch set uploaded (by Bartosz Dziewoński; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/FlaggedRevs@wmf/1.44.0-wmf.4] Pass context to 'revreview-pending-basic' on history page

https://gerrit.wikimedia.org/r/1097381

Change #1095312 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Use Contexts for Message objects in review dialog (tooltip)

https://gerrit.wikimedia.org/r/1095312

Thanks for fixing the remaining problems @Wargo. I'll schedule these patches for deployment about an hour from now (https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20241125T1400).

Change #1095312 had a related patch set uploaded (by Wargo; author: Wargo):

[mediawiki/extensions/FlaggedRevs@master] Use Contexts for Message objects.

https://gerrit.wikimedia.org/r/1095312

Not a bad idea, but the messages using {{FULLPAGENAMEE}} would actually have worked correctly if they used the global context from RequestContext::getMain()->msg( … ), they only don't work because they used wfMessage( … ) (which would previously fall back to the global context, but now it doesn't).

It's time to return to work on this debt?
https://gerrit.wikimedia.org/g/mediawiki/extensions/FlaggedRevs/+/395370d8ca98f7a2e80bd06cdcc00d8eb78ddef8/includes/frontend/FlaggablePageView.php#93
https://gerrit.wikimedia.org/g/mediawiki/extensions/FlaggedRevs/+/395370d8ca98f7a2e80bd06cdcc00d8eb78ddef8/includes/frontend/FlaggedRevsHTML.php#231

I listed every message in FlaggedRevs that uses {{FULLPAGENAMEE}} (or similar magic words, but there aren't any such messages), then looked at the code that uses them. It looks like all of the uses in FlaggedRevsHTML.php need to be updated, and everything else is already fine.

This patch fixes the message shown on the page history view (exactly following the original replication steps), but as I was reviewing it, I realized that the same issue is present in at least one more place: the "Checked" / "Pending" tooltip on the page reading view. (This is the only one I found, but I haven't tested the whole extension carefully.)

Change #1094402 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Pass context to 'revreview-pending-basic' on history page

https://gerrit.wikimedia.org/r/1094402

Change #1094402 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/FlaggedRevs@master] Pass context to messages

https://gerrit.wikimedia.org/r/1094402

Some additional discussion can be found at https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Special%3ABadtitle_in_pending_changes_notice

Here is JavaScript to fix it right away at a given wiki:

I want to point out that this problem has significant impact on Wikipedia versions with many pending changes like de.Wikipedia (>18,000) and pl.Wikipedia (>11,000). It is still possible to review pages by using the history, but not all users know that.

"Badtitle/Message" only comes from one place: https://codesearch.wmcloud.org/search/?q=Badtitle%2FMessage

Monitoring for sustained latency impact on low-traffic jobs is now live.

thanks

This fixed the original issue.
I worry this was caused by delay with updating metadata and all uses of removed calls in other extensions needs to be tested.

I can't remember it happening.

@Giftpflanze: Could you please answer the last comment? Thanks in advance!

Change #1089978 abandoned by Novem Linguae:

[mediawiki/extensions/FlaggedRevs@master] PendingChangesPager: change heading name

https://gerrit.wikimedia.org/r/1089978

Patch is written and merged. I'm leaning towards marking this ticket as resolved unless there's further comments. The patch changed things to look like this:

I tried to rephrase the description to be easier to understand (I hope I understood it correctly). However, when I tried to reproduce it on test2wiki, I couldn’t – when I opened VisualEditor, the FlaggedRevs interface disappeared, and when I published the edit, it didn’t come back, so there was no button that could have worked incorrectly. Well that’s also a way to fix this bug…

In T326934#10227250, @mszabo wrote:

QA Notes (for r1078969, r1079298)
...