[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T378424

PHP 8.4: Implicitly nullable parameter declarations deprecated in qrcode vendor libs
Open, Needs TriagePublic
Actions

Description

Related to T376276: PHP 8.4: Implicitly nullable parameter declarations deprecated

Affects at least OATHAuth and UrlShortener, both currently have 4.5.2 of endroid/qr-code

Deprecated: Endroid\QrCode\Builder\Builder::buildObject(): Implicitly marking parameter $optionsPrefix as nullable is deprecated, the explicit nullable type must be used instead in /var/www/wiki/mediawiki/core/vendor/endroid/qr-code/src/Builder/Builder.php on line 245

Deprecated: Endroid\QrCode\Writer\PngWriter::write(): Implicitly marking parameter $logo as nullable is deprecated, the explicit nullable type must be used instead in /var/www/wiki/mediawiki/core/vendor/endroid/qr-code/src/Writer/PngWriter.php on line 22

Deprecated: Endroid\QrCode\Writer\PngWriter::write(): Implicitly marking parameter $label as nullable is deprecated, the explicit nullable type must be used instead in /var/www/wiki/mediawiki/core/vendor/endroid/qr-code/src/Writer/PngWriter.php on line 22

Deprecated: Endroid\QrCode\Writer\WriterInterface::write(): Implicitly marking parameter $logo as nullable is deprecated, the explicit nullable type must be used instead in /var/www/wiki/mediawiki/core/vendor/endroid/qr-code/src/Writer/WriterInterface.php on line 15

Deprecated: Endroid\QrCode\Writer\WriterInterface::write(): Implicitly marking parameter $label as nullable is deprecated, the explicit nullable type must be used instead in /var/www/wiki/mediawiki/core/vendor/endroid/qr-code/src/Writer/WriterInterface.php on line 15

Deprecated: Endroid\QrCode\Writer\SvgWriter::write(): Implicitly marking parameter $logo as nullable is deprecated, the explicit nullable type must be used instead in /var/www/wiki/mediawiki/core/vendor/endroid/qr-code/src/Writer/SvgWriter.php on line 23

Deprecated: Endroid\QrCode\Writer\SvgWriter::write(): Implicitly marking parameter $label as nullable is deprecated, the explicit nullable type must be used instead in /var/www/wiki/mediawiki/core/vendor/endroid/qr-code/src/Writer/SvgWriter.php on line 23

Deprecated: Endroid\QrCode\QrCode::__construct(): Implicitly marking parameter $encoding as nullable is deprecated, the explicit nullable type must be used instead in /var/www/wiki/mediawiki/core/vendor/endroid/qr-code/src/QrCode.php on line 27

Deprecated: Endroid\QrCode\QrCode::__construct(): Implicitly marking parameter $errorCorrectionLevel as nullable is deprecated, the explicit nullable type must be used instead in /var/www/wiki/mediawiki/core/vendor/endroid/qr-code/src/QrCode.php on line 27

Deprecated: Endroid\QrCode\QrCode::__construct(): Implicitly marking parameter $roundBlockSizeMode as nullable is deprecated, the explicit nullable type must be used instead in /var/www/wiki/mediawiki/core/vendor/endroid/qr-code/src/QrCode.php on line 27

Deprecated: Endroid\QrCode\QrCode::__construct(): Implicitly marking parameter $foregroundColor as nullable is deprecated, the explicit nullable type must be used instead in /var/www/wiki/mediawiki/core/vendor/endroid/qr-code/src/QrCode.php on line 27

Deprecated: Endroid\QrCode\QrCode::__construct(): Implicitly marking parameter $backgroundColor as nullable is deprecated, the explicit nullable type must be used instead in /var/www/wiki/mediawiki/core/vendor/endroid/qr-code/src/QrCode.php on line 27

Deprecated: Endroid\QrCode\Label\Label::__construct(): Implicitly marking parameter $font as nullable is deprecated, the explicit nullable type must be used instead in /var/www/wiki/mediawiki/core/vendor/endroid/qr-code/src/Label/Label.php on line 24

Deprecated: Endroid\QrCode\Label\Label::__construct(): Implicitly marking parameter $alignment as nullable is deprecated, the explicit nullable type must be used instead in /var/www/wiki/mediawiki/core/vendor/endroid/qr-code/src/Label/Label.php on line 24

Deprecated: Endroid\QrCode\Label\Label::__construct(): Implicitly marking parameter $margin as nullable is deprecated, the explicit nullable type must be used instead in /var/www/wiki/mediawiki/core/vendor/endroid/qr-code/src/Label/Label.php on line 24

Deprecated: Endroid\QrCode\Label\Label::__construct(): Implicitly marking parameter $textColor as nullable is deprecated, the explicit nullable type must be used instead in /var/www/wiki/mediawiki/core/vendor/endroid/qr-code/src/Label/Label.php on line 24

Deprecated: BaconQrCode\Encoder\Encoder::chooseMode(): Implicitly marking parameter $encoding as nullable is deprecated, the explicit nullable type must be used instead in /var/www/wiki/mediawiki/core/vendor/bacon/bacon-qr-code/src/Encoder/Encoder.php on line 158

Deprecated: BaconQrCode\Common\ReedSolomonCodec::decode(): Implicitly marking parameter $erasures as nullable is deprecated, the explicit nullable type must be used instead in /var/www/wiki/mediawiki/core/vendor/bacon/bacon-qr-code/src/Common/ReedSolomonCodec.php on line 225

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT376276 PHP 8.4: Implicitly nullable parameter declarations deprecated
 OpenNoneT379587 PHP 8.4: Implicitly nullable parameter declarations deprecated in 3rd party vendor libs
 OpenNoneT378424 PHP 8.4: Implicitly nullable parameter declarations deprecated in qrcode vendor libs
 OpenNoneT328922 Drop PHP 8.0 support from MediaWiki
 StalledKrinkleT319432 Migrate WMF production from PHP 7.4 to PHP 8.1
 ResolvedtstarlingT292552 Rename articles and users to update our case mapping to PHP 7.4 and Unicode 11
 ResolvedJdforrester-WMFT316078 Make PHP 8.1 voting on development (master) branch of MW ecosystem (core, extensions, skins, libraries)
 ResolvedJdforrester-WMFT319065 All Wikimedia production extensions and skins must support PHP 8.1
 ResolvedtstarlingT314212 str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated
 ResolvedReedyT311448 Echo PHP 8.1 support
 ResolvedBUG REPORTtstarlingT289925 FILTER_SANITIZE_STRING is deprecated in PHP 8.1
 ResolvedtstarlingT320726 Fix RandomImageGenerator as used in tests to work on PHP 8.1 without errors or warnings
 ResolvedDaimonaT311451 Re-enable PHP 8.1 CI on css-sanitizer
 ResolvedDaimonaT311452 Taint Check Plugin release
 ResolvedNoneT307506 Address PHP 8.1 job failures on various PHP libs
 ResolvedJdforrester-WMFT311450 Re-enable PHP 8.1 CI on RemexHTML
 ResolvedBUG REPORTNoneT308406 RemexHtml should support PHP 8.1
 ResolvedtstarlingT307630 mediawiki/libs/RemexHtml phan issues under 8.1
 ResolvedJdforrester-WMFT311463 Re-enable PHP 8.1 CI on Zest
 ResolvedssastryT307632 mediawiki/libs/Zest phan issues under 8.1
 ResolvedkostajhT321600 GrowthExperiments PHP 8.1 support
 ResolvedkostajhT321691 StructuredDiscussions support for PHP 8.1
 ResolvedthiemowmdeT321692 FileImporter support for PHP 8.1
 ResolvedtstarlingT322098 GeoData support for PHP 8.1
 ResolvedtstarlingT322099 TwoColConflict support for PHP 8.1
 ResolvedBUG REPORTLucas_Werkmeister_WMDET319219 Wikibase gives deprecated warnings on php 8.1
 ResolvedhooT301249 Handle deprecation of Serializable interface in Wikibase
 ResolvedhooT305785 Wikibase Snak hashes (and thus "mainsnak", "references" and "qualifiers" hashes) depend on legacy PHP serialization
 ResolvedJdforrester-WMFT322233 PageViewInfo support for PHP 8.1
 ResolvedthiemowmdeT322408 CirrusSearch support for PHP 8.1
 ResolvedkostajhT322838 PageTriage PHP 8.1 support
 ResolvedUmherirrenderT323056 STVTallierTest::testFinishTally() fails under PHP 8.0 and later
 ResolvedPRODUCTION ERROR• brookeT289189 getid3: PHP Warning: Division by zero
 ResolvedTheresNoTimeT332356 function strftime() is deprecated in php8.1 used by Calendar extension
 ResolvedtstarlingT322278 MediaWiki core should pass Phan on PHP 8.1
 OpenJdforrester-WMFT320818 Configure CI to test the Wikimedia production gate code against PHP 8.1 as well as PHP 7.4
 ResolvedlarissagauliaT321709 PHP 8.1 Upgrade Performance <-> SRE Service Ops coordination
 ResolvedJMeybohmT345561 Upgrade the MediaWiki servers to ICU 67
 ResolvedMoritzMuehlenhoffT350767 Rebuild PHP 7.4 packages for Bullseye
 OpenNoneT373752 Build php-uuid package, and add to WMF production and CI
 DuplicateNoneT378043 Route requests with PHP_ENGINE=8.1 cookie to "next" deployment via ATS plugin
 OpenScott_FrenchT377042 Support cookie-driven fractional migration to PHP 8.1 deployments of mw-web and mw-api-ext
 OpenScott_FrenchT377040 Turn up PHP 8.1-flavored k8s deployments for all MediaWiki services
 ResolvedKrinkleT377987 Prepare sticky cookie for gradual PHP 8.1 rollout
 ResolvedScott_FrenchT372603 Regenerate UcfirstOverrides.php for PHP 7.4 -> 8.1 transition
 OpenNoneT379874 PHP 8.1 issues found during WMF rollout/ramp up
 ResolvedPRODUCTION ERRORReedyT379834 PHP Deprecated: Automatic conversion of false to array is deprecated
 OpenNoneT343229 Scribunto's use of dynamic Parser::$scribunto_engine should be rewritten/removed
 ResolvedReedyT324891 Deprecated: Creation of dynamic property Parser::$scribunto_engine is deprecated
 OpenNoneT343226 TemplateStyles's use of dynamic Parser::$extTemplateStylesCache should be rewritten/removed
 ResolvedReedyT324890 Deprecated: Creation of dynamic property Parser::$extTemplateStylesCache is deprecated in Hooks.php on line 208
 In ProgressScott_FrenchT372604 Turn up PHP 8.1-flavored mw-debug k8s deployment
 OpendduvallT370934 Build and publish multiple MediaWiki production images for a given set of PHP versions
 ResolvedClement_GoubertT376895 mw-debug-repl fails with `container mediawiki-pinkunicorn-app is not valid for pod mw-debug.codfw.next-5d785576b4-sq6dv`
 OpenScott_FrenchT372605 Extend x-wikimedia-debug-routing.lua to support PHP 8.1 mw-debug deployment
 OpenNoneT379986 Testing and verification of MediaWiki on PHP 8.1 in mwdebug-next
 ResolvedJdforrester-WMFT359868 Drop PHP 7.4 and 8.0 support from MediaWiki 1.42; require PHP 8.1+
 OpenNoneT363639 web-auth/webauthn-lib must be upgraded to 4+ for PHP 8 support
 OpenNoneT358666 Drop PHP 8.1 support from MediaWiki

Event Timeline

Reedy created this task.Mon, Oct 28, 10:13 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMon, Oct 28, 10:13 PM
Reedy added a comment.Mon, Oct 28, 10:16 PM

https://github.com/endroid/qr-code/commit/61cc3ef6863936b58e0cbe63a44da79efe3c84cd in >= 6.0.0

Unfortunately, https://github.com/endroid/qr-code/releases/tag/6.0.0 drops 8.1 support to add 8.4

https://github.com/Bacon/BaconQrCode/commit/1b2647581d70b1bdd1d33e3ce950139eee339829 in >= 3.0.0

Which requires PHP ^8.1

Reedy moved this task from Backlog to Patch released upstream on the Upstream board.Mon, Oct 28, 10:17 PM
Reedy added subtasks: T328922: Drop PHP 8.0 support from MediaWiki, T358666: Drop PHP 8.1 support from MediaWiki.
Reedy renamed this task from PHP 8.4: Implicitly nullable parameter declarations deprecated in OATHAuth vendor libs to PHP 8.4: Implicitly nullable parameter declarations deprecated in qrcode vendor libs.Mon, Oct 28, 10:19 PM
Reedy added a project: MediaWiki-extensions-UrlShortener.
Reedy updated the task description. (Show Details)

Depending if there's any breaking API changes... We might be able to "just" support older and newer versions...

Reedy moved this task from Backlog to Bundled extensions/skins on the PHP 8.4 support board.Tue, Nov 5, 11:41 PM
Reedy added a parent task: T376276: PHP 8.4: Implicitly nullable parameter declarations deprecated.Sun, Nov 10, 2:06 AM
Reedy edited parent tasks, added: T379587: PHP 8.4: Implicitly nullable parameter declarations deprecated in 3rd party vendor libs; removed: T376276: PHP 8.4: Implicitly nullable parameter declarations deprecated.Mon, Nov 11, 10:30 PM
Reedy mentioned this in T379587: PHP 8.4: Implicitly nullable parameter declarations deprecated in 3rd party vendor libs.Mon, Nov 11, 10:42 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits