[go: up one dir, main page]

Page MenuHomePhabricator

ssastry (Subbu)
User

Projects (19)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 5:34 AM (517 w, 6 d)
Availability
Available
IRC Nick
subbu
LDAP User
Subramanya Sastry
MediaWiki User
SSastry (WMF) [ Global Accounts ]

Recent Activity

Today

ssastry moved T374356: CTT tasks week of 06-Sept-2024 from Backlog to In Progress on the Content-Transform-Team-WIP board.
Mon, Sep 9, 9:15 PM · Patch-For-Review, Content-Transform-Team-WIP
ssastry assigned T374356: CTT tasks week of 06-Sept-2024 to cscott.
Mon, Sep 9, 9:14 PM · Patch-For-Review, Content-Transform-Team-WIP

Thu, Sep 5

ssastry created T374156: Parsoid trips up on "[[ .. ]]" in parser function args in some cases.
Thu, Sep 5, 8:45 PM · Parsoid

Wed, Sep 4

ssastry added a comment to T374046: PHP Warning: MediaWiki\Parser\ParserOutput::collectMetadata: bad type for 'translate-is-translation', set '1' (T373920) [Called from MediaWiki\Parser\ParserOutput::collectMetadata in /srv/mediawiki/php-1.43.0-wmf.21/includes/pa.

Yup, we have the info we need to fix caller sites and the patch above turns it off.

Wed, Sep 4, 6:44 PM · Essential-Work, MW-1.43-notes (1.43.0-wmf.22; 2024-09-10), Content-Transform-Team-WIP, Wikimedia-production-error
ssastry added a comment to T374046: PHP Warning: MediaWiki\Parser\ParserOutput::collectMetadata: bad type for 'translate-is-translation', set '1' (T373920) [Called from MediaWiki\Parser\ParserOutput::collectMetadata in /srv/mediawiki/php-1.43.0-wmf.21/includes/pa.

There is also https://logstash.wikimedia.org/app/discover#/doc/logstash-*/logstash-deploy-1-7.0.0-1-2024.09.04?id=3VIgvpEBa-PL6vFem9kr for "translate-has-languages-tag" which has a very low frequency, but probably also a boolean from the translate extension.

Wed, Sep 4, 6:02 PM · Essential-Work, MW-1.43-notes (1.43.0-wmf.22; 2024-09-10), Content-Transform-Team-WIP, Wikimedia-production-error
ssastry added a comment to T374046: PHP Warning: MediaWiki\Parser\ParserOutput::collectMetadata: bad type for 'translate-is-translation', set '1' (T373920) [Called from MediaWiki\Parser\ParserOutput::collectMetadata in /srv/mediawiki/php-1.43.0-wmf.21/includes/pa.

Comes from https://codesearch.wmcloud.org/deployed/?q=is-translation&files=&excludeFiles=&repos= and as expected, it is a boolean value.

Wed, Sep 4, 5:57 PM · Essential-Work, MW-1.43-notes (1.43.0-wmf.22; 2024-09-10), Content-Transform-Team-WIP, Wikimedia-production-error
ssastry updated subscribers of T374046: PHP Warning: MediaWiki\Parser\ParserOutput::collectMetadata: bad type for 'translate-is-translation', set '1' (T373920) [Called from MediaWiki\Parser\ParserOutput::collectMetadata in /srv/mediawiki/php-1.43.0-wmf.21/includes/pa.

Yes, these are warnings @Jdforrester-WMF logged yday (as part of https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1070326 ) to help us better fix the underlying issue -- the code works around it for now, but just is a noisy log. My recommendation is to filter out this warning and proceed. FYI. @cscott

Wed, Sep 4, 5:53 PM · Essential-Work, MW-1.43-notes (1.43.0-wmf.22; 2024-09-10), Content-Transform-Team-WIP, Wikimedia-production-error
ssastry added a comment to T373776: Parsoid does not correctly render <noinclude> if used with templates.

We understand the need to replicate legacy parser behavior and that it should work in all namespaces. Parsoid's design is different because it has many other requirements besides rendering a page: support HTML editing without dirty diffs, supporting richer markup for tools, and more recently, we have been exploring T363421: Prototype selective HTML updates in Parsoid which can lead to pages being updated upto 5x faster when a dependent template is edited. So, given the overall requirements, we have made design decisions in the past to enable us to meet those goals. I say all that as a preamble to indicate that there are tradeoffs and if a particular wikitext use case is not used often, it is not unreasonable to look for alternatives.

Wed, Sep 4, 5:05 PM · Parsoid-Read-Views, Parsoid
ssastry moved T371875: Wikimedia\Assert\InvariantException: Invariant failed: Bad UTF-8 at start of string (parsoid/src/Html2Wt/SerializerState.php) from Backlog to To Verify on the Content-Transform-Team-WIP board.
Wed, Sep 4, 2:16 PM · Essential-Work, Content-Transform-Team-WIP, Parsoid, Wikimedia-production-error
ssastry closed T372827: Run visualdiff tests on dagwiki and igwiki as Resolved.
Wed, Sep 4, 2:16 PM · Abstract Wikipedia team, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Wikifunctions, Content-Transform-Team-WIP
ssastry moved T373212: Legacy parser rendering showing after VE edit on wikis where Parsoid read-views are deployed (still with the "rendered with Parsoid" tag) from Backlog to To Verify on the Content-Transform-Team-WIP board.
Wed, Sep 4, 2:15 PM · MW-1.43-notes (1.43.0-wmf.21; 2024-09-03), Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ssastry moved T373460: Wikimedia\Assert\InvariantException: Invariant failed: Bad UTF-8 at end of string (2 byte sequence) from Code Review to To Deploy on the Content-Transform-Team-WIP board.
Wed, Sep 4, 2:15 PM · Essential-Work, MW-1.43-notes (1.43.0-wmf.22; 2024-09-10), Content-Transform-Team-WIP, Parsoid, Wikimedia-production-error
ssastry assigned T373374: Interwiki links with translation tags and multiple colons seem broken in Parsoid to cscott.
Wed, Sep 4, 2:15 PM · Patch-For-Review, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP, Parsoid
ssastry assigned T373460: Wikimedia\Assert\InvariantException: Invariant failed: Bad UTF-8 at end of string (2 byte sequence) to ihurbain.
Wed, Sep 4, 2:14 PM · Essential-Work, MW-1.43-notes (1.43.0-wmf.22; 2024-09-10), Content-Transform-Team-WIP, Parsoid, Wikimedia-production-error
ssastry moved T373480: Display categories in sorted order by default from Backlog to In Progress on the Content-Transform-Team-WIP board.
Wed, Sep 4, 2:12 PM · MediaWiki-User-Interface, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP, MW-1.43-notes (1.43.0-wmf.21; 2024-09-03), User-notice
ssastry assigned T373454: [warn/kartographer] Could not add tracking category kartographer-tracking-category to ihurbain.
Wed, Sep 4, 2:12 PM · Content-Transform-Team-WIP, MW-1.43-notes (1.43.0-wmf.20; 2024-08-27), Maps (Kartographer), Wikimedia-production-error
ssastry closed T372935: Parsoid doesn't recognize valid image options on eowikivoyage and lints them as bogus options as Resolved.
Wed, Sep 4, 2:08 PM · MW-1.43-notes (1.43.0-wmf.21; 2024-09-03), Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid, Content-Transform-Team-WIP
ssastry closed T372669: Rendering diff from inclusion in a category (visual diff testing) as Resolved.
Wed, Sep 4, 2:08 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP, Parsoid
ssastry moved T372669: Rendering diff from inclusion in a category (visual diff testing) from To Deploy to To Verify on the Content-Transform-Team-WIP board.
Wed, Sep 4, 2:08 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP, Parsoid
ssastry moved T372935: Parsoid doesn't recognize valid image options on eowikivoyage and lints them as bogus options from To Deploy to To Verify on the Content-Transform-Team-WIP board.
Wed, Sep 4, 2:08 PM · MW-1.43-notes (1.43.0-wmf.21; 2024-09-03), Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid, Content-Transform-Team-WIP
ssastry moved T372810: Deploy Parsoid Read Views to eo/sv/fi wikivoyages from In Progress to To Verify on the Content-Transform-Team-WIP board.
Wed, Sep 4, 2:06 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP
ssastry moved T372789: Compact Parsoid indicator for ParserMigration for wikivoyage from Current Deploy Target to To Verify on the Content-Transform-Team-WIP board.
Wed, Sep 4, 2:05 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), MW-1.43-notes (1.43.0-wmf.19; 2024-08-20), Parsoid, MediaWiki-extensions-ParserMigration, Content-Transform-Team-WIP
ssastry renamed T373389: Parsoid should improve its detection of empty-lines and suppress their interference in token handllers from Parsoid should improves its detection of empty-lines and suppress their interference in token handllers to Parsoid should improve its detection of empty-lines and suppress their interference in token handllers.
Wed, Sep 4, 2:05 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP, Parsoid
ssastry closed T372889: CSS issue in a navbox on jawikivoyage (causes visual diffs on a number of pages) as Resolved.
Wed, Sep 4, 1:00 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP

Tue, Sep 3

ssastry added a comment to T373776: Parsoid does not correctly render <noinclude> if used with templates.

How common is this pattern where wikitext strings are stictched together across <noinclude> / <includeonly> blocks? Parsoid currently doesn't support it (by design) - it treats contents of <noinclude> / <includeonly> blocks are self-contained. We can revisit that design decision if really necessary -- but before we take that on, we would like to understand if this pattern is specific to a few pages on a this wiki and if there are alternative wikitext formulations that can work instead.

Tue, Sep 3, 2:57 PM · Parsoid-Read-Views, Parsoid

Fri, Aug 30

ssastry merged T373674: Parsoid on mobile: all sections are expanded by default, regardless of user preference into T371539: Sections in Parsoid HTML should be collapsed by default.
Fri, Aug 30, 2:12 PM · Web-Team-Backlog (FY2024-25 Q1 Sprint 5), MW-1.43-notes (1.43.0-wmf.21; 2024-09-03), Web Team Essential Work 2024 (Support parser migration), Parsoid (Tracking), MobileFrontend
ssastry merged task T373674: Parsoid on mobile: all sections are expanded by default, regardless of user preference into T371539: Sections in Parsoid HTML should be collapsed by default.
Fri, Aug 30, 2:11 PM · Parsoid, Parsoid-Read-Views

Tue, Aug 27

ssastry added a comment to T373480: Display categories in sorted order by default.

Some questions: I suppose that is enforced by editors writing categories in the desired order at the end of the article? But, if a template in the middle of the article (or an infobox) adds a category, I imagine it shows up wherever it showed up in text, right? So, to Scott's question, it is not quite a set, but it an ordered list with the output being generate in textual order?

Tue, Aug 27, 8:17 PM · MediaWiki-User-Interface, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP, MW-1.43-notes (1.43.0-wmf.21; 2024-09-03), User-notice

Mon, Aug 26

ssastry created T373400: Bug in HandleParsoidSectionLinks - seems to skip some headings?.
Mon, Aug 26, 10:00 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP
ssastry moved T372810: Deploy Parsoid Read Views to eo/sv/fi wikivoyages from Current Deploy Target to In Progress on the Content-Transform-Team-WIP board.
Mon, Aug 26, 9:03 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP
ssastry moved T373229: Deploy to next set of wikivoyages (ps,bn,hi,tr) week of Sep 9 from Current Deploy Target to In Progress on the Content-Transform-Team-WIP board.
Mon, Aug 26, 9:03 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid, Content-Transform-Team-WIP
ssastry renamed T372810: Deploy Parsoid Read Views to eo/sv/fi wikivoyages from Run visualdiff on ja, eo, uk, bn, and ro in Wikivoyage to Roll out ja, eo, uk, bn, and ro wikivoyages.
Mon, Aug 26, 9:02 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP
ssastry updated the task description for T373229: Deploy to next set of wikivoyages (ps,bn,hi,tr) week of Sep 9.
Mon, Aug 26, 9:02 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid, Content-Transform-Team-WIP
ssastry updated the task description for T373389: Parsoid should improve its detection of empty-lines and suppress their interference in token handllers.
Mon, Aug 26, 7:48 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP, Parsoid
ssastry created T373389: Parsoid should improve its detection of empty-lines and suppress their interference in token handllers.
Mon, Aug 26, 7:47 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP, Parsoid
ssastry renamed T372675: Parsoid matches closing *include* tags differently than legacy causing edge case rendering diffs in some cases from Rendering diff on template page (visual diff testing) to Parsoid matches closing *include* tags differently than legacy causing edge case rendering diffs in some cases.
Mon, Aug 26, 7:38 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP, Parsoid
ssastry claimed T373229: Deploy to next set of wikivoyages (ps,bn,hi,tr) week of Sep 9.
Mon, Aug 26, 4:00 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid, Content-Transform-Team-WIP
ssastry removed a project from T371125: When using Parsoid rendering, DiscussionTools "empty state" appears on all talk pages: Parsoid.
Mon, Aug 26, 2:35 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), MW-1.43-notes (1.43.0-wmf.19; 2024-08-20), Content-Transform-Team-WIP, DiscussionTools
ssastry created T373284: Extlink followed by a template parsed incorrectly (visualdiff on ukwikivoyage page).
Mon, Aug 26, 2:35 AM · Content-Transform-Team, Parsoid-Read-Views, Parsoid
ssastry updated the task description for T373258: Build selective update functionality in Parsoid to efficiently support structured fragment generators.
Mon, Aug 26, 1:28 AM · OKR-Work, Abstract Wikipedia team, Content-Transform-Team-WIP, Parsoid, Wikifunctions

Sun, Aug 25

ssastry added a parent task for T371713: Instrumentation & data gathering to inform future performance & templating improvements: T373258: Build selective update functionality in Parsoid to efficiently support structured fragment generators.
Sun, Aug 25, 12:49 AM · MW-1.43-notes (1.43.0-wmf.20; 2024-08-27), OKR-Work, Patch-For-Review, MediaWiki-Parser, Content-Transform-Team-WIP
ssastry added a subtask for T373258: Build selective update functionality in Parsoid to efficiently support structured fragment generators: T371713: Instrumentation & data gathering to inform future performance & templating improvements.
Sun, Aug 25, 12:49 AM · OKR-Work, Abstract Wikipedia team, Content-Transform-Team-WIP, Parsoid, Wikifunctions
ssastry added a parent task for T363421: Prototype selective HTML updates in Parsoid: T373258: Build selective update functionality in Parsoid to efficiently support structured fragment generators.
Sun, Aug 25, 12:49 AM · OKR-Work, Content-Transform-Team-WIP, Patch-For-Review, Wikimedia-Hackathon-2024, Parsoid
ssastry added a subtask for T373258: Build selective update functionality in Parsoid to efficiently support structured fragment generators: T363421: Prototype selective HTML updates in Parsoid.
Sun, Aug 25, 12:49 AM · OKR-Work, Abstract Wikipedia team, Content-Transform-Team-WIP, Parsoid, Wikifunctions
ssastry created T373258: Build selective update functionality in Parsoid to efficiently support structured fragment generators.
Sun, Aug 25, 12:48 AM · OKR-Work, Abstract Wikipedia team, Content-Transform-Team-WIP, Parsoid, Wikifunctions
ssastry created T373257: Pick wikitext syntax for wikifunction calls.
Sun, Aug 25, 12:34 AM · OKR-Work, Abstract Wikipedia team, Content-Transform-Team-WIP, Parsoid, Wikifunctions
ssastry created T373256: Define ParserCache strategy for pages with content placeholder slots (as with wikifunctions).
Sun, Aug 25, 12:32 AM · Content-Transform-Team, Parsoid, Wikifunctions
ssastry created T373255: Define the wikifunctions API that Parsoid needs.
Sun, Aug 25, 12:18 AM · Content-Transform-Team, Wikifunctions, Parsoid
ssastry created T373253: Develop semantic / distinct representation for wikifunctions output in Parsoid DOM.
Sun, Aug 25, 12:12 AM · Content-Transform-Team, Wikifunctions, Parsoid
ssastry created T373252: Ensure Parsoid can issue batch precompute requests for external services like wikifunctions.
Sun, Aug 25, 12:00 AM · Content-Transform-Team, Wikifunctions, Parsoid

Fri, Aug 23

ssastry created T373229: Deploy to next set of wikivoyages (ps,bn,hi,tr) week of Sep 9.
Fri, Aug 23, 9:12 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid, Content-Transform-Team-WIP
ssastry triaged T371713: Instrumentation & data gathering to inform future performance & templating improvements as High priority.
Fri, Aug 23, 8:13 PM · MW-1.43-notes (1.43.0-wmf.20; 2024-08-27), OKR-Work, Patch-For-Review, MediaWiki-Parser, Content-Transform-Team-WIP
ssastry added a comment to T372889: CSS issue in a navbox on jawikivoyage (causes visual diffs on a number of pages).

Ya, I don't think this is a generic hlist issue -- Parsoid's HTML for wikitext lists already include the newline (the newline found in source wikitext) -- so I am not sure the hlist issue affects anything else. If it were, we would have heard this long back because hlist is used on lots of wikis.

Fri, Aug 23, 4:07 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP

Thu, Aug 22

ssastry added a comment to T371353: Deploy Parsoid Read Views for cs/ro wikivoyage.
NOTE: While the title mentions cs,hi,shn, , besides these five, we also evaluated ro, eo, bn, ja, uk additionally (T372810). Based on visualdiff results, we decided to pick cswikivoyage and rowikivoyage now (as above).
Thu, Aug 22, 9:34 PM · OKR-Work, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP
ssastry renamed T371353: Deploy Parsoid Read Views for cs/ro wikivoyage from Deploy Parsoid Read Views for cs, ro, hi, shn, ps wikivoyage to Deploy Parsoid Read Views for cs, tr, hi, shn, ps wikivoyage.
Thu, Aug 22, 9:32 PM · OKR-Work, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP
ssastry renamed T371353: Deploy Parsoid Read Views for cs/ro wikivoyage from Deploy Parsoid Read Views for cs, hi, shn, ps wikivoyage to Deploy Parsoid Read Views for cs, ro, hi, shn, ps wikivoyage.
Thu, Aug 22, 9:24 PM · OKR-Work, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP
ssastry closed T371142: Add a new "fostered-transparent" lint category for when all the fostered content in rendering transparent as Resolved.

https://en.wikipedia.org/wiki/Special:LintErrors/fostered-transparent now exists.

Thu, Aug 22, 8:46 PM · Patch-For-Review, Content-Transform-Team-WIP, Essential-Work, MediaWiki-extensions-Linter
ssastry closed T372574: CTT tasks week of 2024-08-16 as Resolved.
Thu, Aug 22, 8:25 PM · MW-1.43-notes (1.43.0-wmf.19; 2024-08-20), Patch-For-Review, Essential-Work, Content-Transform-Team-WIP
ssastry updated the task description for T372574: CTT tasks week of 2024-08-16.
Thu, Aug 22, 8:25 PM · MW-1.43-notes (1.43.0-wmf.19; 2024-08-20), Patch-For-Review, Essential-Work, Content-Transform-Team-WIP
ssastry created T373146: CTT tasks week of 2024-08-23.
Thu, Aug 22, 8:24 PM · Essential-Work, MW-1.43-notes (1.43.0-wmf.20; 2024-08-27), Patch-For-Review, Content-Transform-Team-WIP
ssastry added a comment to T372574: CTT tasks week of 2024-08-16.

@ssastry Maybe you can follow up restoring the cluster graphs from T371126#10067372

Thu, Aug 22, 8:11 PM · MW-1.43-notes (1.43.0-wmf.19; 2024-08-20), Patch-For-Review, Essential-Work, Content-Transform-Team-WIP
ssastry closed T371745: [error/wt2html] TableFixups: Failed to successfully reparse {{fbu|20|SCO}}|| as table cell attributes as Resolved.

The extra noise has disappeared. The actual table reparse issues will be handled separately.

Thu, Aug 22, 7:53 PM · Content-Transform-Team-WIP, Essential-Work, Parsoid, Wikimedia-production-error
ssastry updated the task description for T372574: CTT tasks week of 2024-08-16.
Thu, Aug 22, 3:45 PM · MW-1.43-notes (1.43.0-wmf.19; 2024-08-20), Patch-For-Review, Essential-Work, Content-Transform-Team-WIP
ssastry added a comment to T372889: CSS issue in a navbox on jawikivoyage (causes visual diffs on a number of pages).

Looks like this is very specific to Cite references output (from the navbox) and the CSS expects a newline between the "</li><li>".

Thu, Aug 22, 1:55 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP

Wed, Aug 21

ssastry closed T372019: Rendering diff from DiscussionTools not handling headings at the top level of templates (visual diff testing) as Resolved.

Looks fixed to me! \o/

Wed, Aug 21, 1:57 PM · MW-1.43-notes (1.43.0-wmf.19; 2024-08-20), Content-Transform-Team-WIP, Parsoid, DiscussionTools, Parsoid-Read-Views
ssastry merged task T372940: Comment not recognized in Parsoid rendering on a DT page into T372019: Rendering diff from DiscussionTools not handling headings at the top level of templates (visual diff testing).
Wed, Aug 21, 1:57 PM · Content-Transform-Team, Parsoid-Read-Views, Editing-team, Parsoid, DiscussionTools
ssastry reopened T372019: Rendering diff from DiscussionTools not handling headings at the top level of templates (visual diff testing) as "Open".

Ooops merged the wrong way.

Wed, Aug 21, 1:56 PM · MW-1.43-notes (1.43.0-wmf.19; 2024-08-20), Content-Transform-Team-WIP, Parsoid, DiscussionTools, Parsoid-Read-Views
ssastry merged T372019: Rendering diff from DiscussionTools not handling headings at the top level of templates (visual diff testing) into T372940: Comment not recognized in Parsoid rendering on a DT page.
Wed, Aug 21, 1:56 PM · Content-Transform-Team, Parsoid-Read-Views, Editing-team, Parsoid, DiscussionTools
ssastry merged T372940: Comment not recognized in Parsoid rendering on a DT page into T372019: Rendering diff from DiscussionTools not handling headings at the top level of templates (visual diff testing).
Wed, Aug 21, 1:56 PM · MW-1.43-notes (1.43.0-wmf.19; 2024-08-20), Content-Transform-Team-WIP, Parsoid, DiscussionTools, Parsoid-Read-Views
ssastry merged task T372019: Rendering diff from DiscussionTools not handling headings at the top level of templates (visual diff testing) into T372940: Comment not recognized in Parsoid rendering on a DT page.
Wed, Aug 21, 1:55 PM · MW-1.43-notes (1.43.0-wmf.19; 2024-08-20), Content-Transform-Team-WIP, Parsoid, DiscussionTools, Parsoid-Read-Views
ssastry added a comment to T372940: Comment not recognized in Parsoid rendering on a DT page.

You are right indeed - that looks fixed with this morning's production rollout to group1 wikis!

Wed, Aug 21, 1:54 PM · Content-Transform-Team, Parsoid-Read-Views, Editing-team, Parsoid, DiscussionTools

Tue, Aug 20

ssastry added a comment to T372019: Rendering diff from DiscussionTools not handling headings at the top level of templates (visual diff testing).

I guess this will get fixed tomorrow when the train rolls out!

Tue, Aug 20, 9:57 PM · MW-1.43-notes (1.43.0-wmf.19; 2024-08-20), Content-Transform-Team-WIP, Parsoid, DiscussionTools, Parsoid-Read-Views
ssastry merged T372951: With Parsoid HTML, some headings on DiscussionTools pages are styled differently into T372019: Rendering diff from DiscussionTools not handling headings at the top level of templates (visual diff testing).
Tue, Aug 20, 9:57 PM · MW-1.43-notes (1.43.0-wmf.19; 2024-08-20), Content-Transform-Team-WIP, Parsoid, DiscussionTools, Parsoid-Read-Views
ssastry merged task T372951: With Parsoid HTML, some headings on DiscussionTools pages are styled differently into T372019: Rendering diff from DiscussionTools not handling headings at the top level of templates (visual diff testing).
Tue, Aug 20, 9:56 PM · Editing-team, Content-Transform-Team, Parsoid-Read-Views, Parsoid, DiscussionTools
ssastry added a comment to T372940: Comment not recognized in Parsoid rendering on a DT page.

See the very first section ( Latest comment: 10 months ago1 comment1 person in discussion ) ... you can also see the diff in the TOC on the left (which is how I first noticed it).

Tue, Aug 20, 9:50 PM · Content-Transform-Team, Parsoid-Read-Views, Editing-team, Parsoid, DiscussionTools
ssastry created T372951: With Parsoid HTML, some headings on DiscussionTools pages are styled differently.
Tue, Aug 20, 9:26 PM · Editing-team, Content-Transform-Team, Parsoid-Read-Views, Parsoid, DiscussionTools
ssastry created T372940: Comment not recognized in Parsoid rendering on a DT page.
Tue, Aug 20, 9:18 PM · Content-Transform-Team, Parsoid-Read-Views, Editing-team, Parsoid, DiscussionTools
ssastry added a comment to T372889: CSS issue in a navbox on jawikivoyage (causes visual diffs on a number of pages).

Indeed. This is almost certainly a wontfix. For Parsoid, they should probably disable the nowrap CSS rule.

Tue, Aug 20, 9:16 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP
ssastry added a project to T372709: Missing cite error message and category: Content-Transform-Team.
Tue, Aug 20, 8:35 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP, Patch-For-Review, WMDE-TechWish-Sprint-2024-08-21, WMDE-References-FocusArea, WMDE-TechWish-Sprint-2024-08-13, Parsoid
ssastry moved T372669: Rendering diff from inclusion in a category (visual diff testing) from Current Deploy Target to Code Review on the Content-Transform-Team-WIP board.
Tue, Aug 20, 8:10 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP, Parsoid
ssastry moved T372935: Parsoid doesn't recognize valid image options on eowikivoyage and lints them as bogus options from Current Deploy Target to Code Review on the Content-Transform-Team-WIP board.
Tue, Aug 20, 8:09 PM · MW-1.43-notes (1.43.0-wmf.21; 2024-09-03), Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid, Content-Transform-Team-WIP
ssastry moved T372935: Parsoid doesn't recognize valid image options on eowikivoyage and lints them as bogus options from Backlog to Current Deploy Target on the Content-Transform-Team-WIP board.
Tue, Aug 20, 7:49 PM · MW-1.43-notes (1.43.0-wmf.21; 2024-09-03), Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid, Content-Transform-Team-WIP
ssastry created T372935: Parsoid doesn't recognize valid image options on eowikivoyage and lints them as bogus options.
Tue, Aug 20, 7:47 PM · MW-1.43-notes (1.43.0-wmf.21; 2024-09-03), Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid, Content-Transform-Team-WIP
ssastry added a comment to T355664: Translate messages are not styled correctly with Parsoid.

This is probably fixed - someone should verify and close it.

Tue, Aug 20, 5:06 PM · MW-1.43-notes (1.43.0-wmf.19; 2024-08-20), LPL Essential (LPL Essential 2024 Jul-Sep), Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 3 - Main namespace of officewiki / mediawiki.org renders with Parsoid), Parsoid, MediaWiki-extensions-Translate
ssastry reopened T355099: Difference in paragraph wrapping after transclusion end as "Open".

I am going to reopen this because of the discussion on the dupe task -- the patch that caused us to decline it does a slightly different thing (it looks at start of template) than what is needed (look at end of template). It is possible we arrive at the same result and decline it, but worth investigating a bit by starting off of Arlo's patch.

Tue, Aug 20, 4:31 PM · OKR-Work, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Patch-For-Review, Content-Transform-Team-WIP, Parsoid
ssastry triaged T372889: CSS issue in a navbox on jawikivoyage (causes visual diffs on a number of pages) as High priority.
Tue, Aug 20, 4:30 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP
ssastry reopened T355099: Difference in paragraph wrapping after transclusion end, a subtask of T371640: [EPIC] Deploy Parsoid Read Views for all Wikivoyage wikis, as Open.
Tue, Aug 20, 4:30 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Epic, Content-Transform-Team-WIP, OKR-Work
ssastry updated the task description for T372574: CTT tasks week of 2024-08-16.
Tue, Aug 20, 3:56 PM · MW-1.43-notes (1.43.0-wmf.19; 2024-08-20), Patch-For-Review, Essential-Work, Content-Transform-Team-WIP
ssastry added a comment to T372888: P-wrapping edge case in Parsoid.

But, looks like I didn't look carefully when I looked at the gerrit patch. The phab task is indeed a duplicate, but the patch fixes the start-meta interruption (according to the commit message) vs the end-meta interruption that the phab task documents.

Tue, Aug 20, 3:53 PM · Content-Transform-Team, Parsoid-Read-Views, Parsoid
ssastry added a comment to T372888: P-wrapping edge case in Parsoid.

Not sure ... This test case is the other edge cases corresponding to the end-meta which you document in that commit message: "Similarly, this should be true for template end metas but there a newline might escape out of the template causing a dirty diff"

Tue, Aug 20, 3:50 PM · Content-Transform-Team, Parsoid-Read-Views, Parsoid
ssastry updated the task description for T372827: Run visualdiff tests on dagwiki and igwiki.
Tue, Aug 20, 3:07 PM · Abstract Wikipedia team, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Wikifunctions, Content-Transform-Team-WIP
ssastry updated the task description for T372810: Deploy Parsoid Read Views to eo/sv/fi wikivoyages.
Tue, Aug 20, 3:07 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP
ssastry removed a project from T372889: CSS issue in a navbox on jawikivoyage (causes visual diffs on a number of pages): Parsoid.
Tue, Aug 20, 1:11 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP
ssastry created T372889: CSS issue in a navbox on jawikivoyage (causes visual diffs on a number of pages).
Tue, Aug 20, 1:11 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP
ssastry created T372888: P-wrapping edge case in Parsoid.
Tue, Aug 20, 1:09 PM · Content-Transform-Team, Parsoid-Read-Views, Parsoid

Mon, Aug 19

ssastry claimed T372810: Deploy Parsoid Read Views to eo/sv/fi wikivoyages.
Mon, Aug 19, 8:57 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP
ssastry removed a project from T372827: Run visualdiff tests on dagwiki and igwiki: Parsoid.
Mon, Aug 19, 8:57 PM · Abstract Wikipedia team, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Wikifunctions, Content-Transform-Team-WIP
ssastry removed a project from T372810: Deploy Parsoid Read Views to eo/sv/fi wikivoyages: Parsoid.
Mon, Aug 19, 8:57 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP
ssastry claimed T372827: Run visualdiff tests on dagwiki and igwiki.
Mon, Aug 19, 8:56 PM · Abstract Wikipedia team, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Wikifunctions, Content-Transform-Team-WIP
ssastry created T372827: Run visualdiff tests on dagwiki and igwiki.
Mon, Aug 19, 8:53 PM · Abstract Wikipedia team, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Wikifunctions, Content-Transform-Team-WIP