Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 16 commits
- 7 files changed
- 8 contributors
Commits on Sep 24, 2019
-
Use -f option when calling ln at install time
This allows "make install; make install" to work properly. Retrieved from: https://git.buildroot.net/buildroot/tree/package/libhttpparser/0001-Use-f-option-when-calling-ln-at-install-time.patch PR-URL: nodejs#492 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> Signed-off-by: Renaud AUBIN <root@renaud.io> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Commits on Feb 6, 2020
-
Support multi-coding Transfer-Encoding
`Transfer-Encoding` header might have multiple codings in it. Even though llhttp cares only about `chunked`, it must check that `chunked` is the last coding (if present). ABNF from RFC 7230: ``` Transfer-Encoding = *( "," OWS ) transfer-coding *( OWS "," [ OWS transfer-coding ] ) transfer-coding = "chunked" / "compress" / "deflate" / "gzip" / transfer-extension transfer-extension = token *( OWS ";" OWS transfer-parameter ) transfer-parameter = token BWS "=" BWS ( token / quoted-string ) ``` However, if `chunked` is not last - llhttp must assume that the encoding and size of the body is unknown (according to 3.3.3 of RFC 7230) and read the response until EOF. For request - the error must be raised for an unknown `Transfer-Encoding`. Furthermore, 3.3.3 of RFC 7230 explicitly states that presence of both `Transfer-Encoding` and `Content-Length` indicates the smuggling attack and "ought to be handled as an error". For the lenient mode: * Unknown `Transfer-Encoding` in requests is not an error and request body is simply read until EOF (end of connection) * Only `Transfer-Encoding: chunked` together with `Content-Length` would result an error (just like before the patch) PR-URL: nodejs-private/http-parser-private#4 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Feb 13, 2020
-
Correct test name and numbering
It doesn't matter yet, but two tests had the same name, and same test position macro. PR-URL: nodejs#497 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Commits on Mar 24, 2020
-
Fix ABI breakage introduced in commit 7d5c99d ("Support multi-coding Transfer-Encoding") by undoing the change in `sizeof(http_parser)`. Restore the size of the `flags` field and shrink the `index` field from 7 to 5 bits. It track strings up to `strlen("Transfer-Encoding")` bytes so 2^5 == 32 is wide enough. Fixes: nodejs#502 PR-URL: nodejs#503 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
-
Commits on Apr 14, 2020
-
Add a first fuzzer for the parser.
PR-URL: nodejs#506 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Commits on Apr 28, 2020
-
Add another fuzzer for the urls.
PR-URL: nodejs#508 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Commits on May 4, 2020
-
Solaris 9 doesn't have stdint.h, use inttypes.h
PR-URL: nodejs#184 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Commits on May 5, 2020
-
PR-URL: nodejs#511 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Commits on May 11, 2020
-
Update http_parser.content_length doc comment.
It's -1 when no Content-Length field is present, not 0. Fixes: nodejs#512 PR-URL: nodejs#513 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Commits on May 15, 2020
-
The operands to `+` are promoted from `uint16_t` to `int` before addition, making the expression `off + len <= buflen` emit a warning because `buflen` is unsigned. Fixes: nodejs#514 PR-URL: nodejs#515 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Commits on Jul 8, 2020
-
Test Content-Length header parsing.
The test suite did very little validation of the Content-Length field until now. Verify for each request and response that the parsed numeric value matches the value from the header field. PR-URL: nodejs#519 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Commits on Jul 10, 2020
-
Allow Content-Length and Transfer-Encoding: chunked
Fixes: nodejs#517 PR-URL: nodejs#518 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Pierce Lopez <pierce.lopez@gmail.com>
-
Fix sizeof(http_parser) assert
The result should be 32 on both 32 bits and 64 bits x86 because of struct padding. Fixes: nodejs#507 PR-URL: nodejs#510 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Commits on Oct 2, 2020
-
doc: add maintenance notice to readme
I'm moving on and as the last (semi-)active maintainer, that means http-parser is now effectively unmaintained. Refs: nodejs#522 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 5c17dad...ec8b5ee