Solaris doesn't necessarily have stdint.h, use inttypes.h #184
Conversation
|
What about |
|
No, it doesn't include |
|
@jacquesg what version of Solaris are you trying to build against? In general, most of the node ecosystem requires illumos or Solaris 10, which based on your doc suggests that we'll always have stdint.h available. |
|
I believe the error is coming from a Solaris 9 sparc machine. We use http parser in libgit2. I'm the maintainer of Git-Raw, the perl bindings. Got the build failures by looking at the ActiveState perl builds. Sent from my iPhone
|
|
I think then we want to constrain this further if possible to S9 and older versions of solaris |
|
So, @tjfontaine should I land it? |
|
@tjfontaine I don't think there is any value in constraining this to Solaris 9 and older. The fix works for all versions, introducing additional conditional logic IMHO would be senseless. |
|
@indutny ... I assume this one is likely safe to close? |
|
Is there any reason this cannot be merged? |
|
@jasnell I have no idea, we clearly need input of Solaris people here. |
|
hmm... I'm not a solaris person either :-/ ... @misterdjules ideas? |
|
On 12/26/16 12:36 , James M Snell wrote:
hmm... I'm not a solaris person either :-/ ... @misterdjules ideas?
In general, <stdint.h> is what user land software is supposed to include
and <sys/inttypes.h> is for device drivers. The problem seems to be that
older versions of Solaris (Solaris 9 and older) don't seem to have that
header. At the moment, it seems that the content from both <stdint.h>
and <sys/inttypes.h> is generally the same, though the set of
pre-processor macros being used could change it so you see less
definitions with only the latter.
I can't really speak for what modern Oracle Solaris has done, only
illumos, though it likely hasn't changed that much between the two.
The original desire to constrain this to older versions is probably so
that we're using the expected header on current systems and so that way
we don't end up in the case where there are additions that have been
made to the standard headers for user land that we somehow miss by
including a device driver header.
Hopefully this helps.
|
|
I've constrained this to Solaris 9. |
|
Anything else required to get this merged? |
|
Is this PR still being considered? |
|
It is still relevant, atleast for me. |
PR-URL: #184 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
I somehow managed to completely overlook this PR for nearly six years, sorry about that. Merged just now in 55e736c, thanks Jacques! |
PR-URL: nodejs#184 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Solaris doesn't necessarily have
stdint.h, it's more portable to usesys/inttypes.h.See:
http://wiki.opencsw.org/porting-faq#toc1