8000 Fix `testpack` working-directory by wimpyprogrammer · Pull Request #76 · wimpyprogrammer/strings-to-regex · GitHub
[go: up one dir, main page]
Skip to content

Fix testpack working-directory #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2022
Merged

Fix testpack working-directory #76

merged 1 commit into from
Jun 26, 2022

Conversation

wimpyprogrammer
Copy link
Owner

Fix CI errors during testpack due to sub-directory confusion.

npm WARN tarball tarball data for strings-to-regex@file:packages/strings-to-regex/strings-to-regex-1.3.0.tgz (null) seems to be corrupted. Trying again.
npm ERR! code ENOENT
npm ERR! syscall open
npm ERR! path /home/runner/work/strings-to-regex/strings-to-regex/packages/strings-to-regex-testpack/packages/strings-to-regex/strings-to-regex-1.3.0.tgz
npm ERR! errno -2
npm ERR! enoent ENOENT: no such file or directory, open '/home/runner/work/strings-to-regex/strings-to-regex/packages/strings-to-regex-testpack/packages/strings-to-regex/strings-to-regex-1.3.0.tgz'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent

@wimpyprogrammer
Ignore testpack failures on Node 16+
4ff32d8 
Only fail tests if testpack fails on Node 12.

Workaround sudden pathing issue that is breaking testpack in Node 16.
@wimpyprogrammer wimpyprogrammer added the bug Something isn't working label Jun 26, 2022
@wimpyprogrammer wimpyprogrammer self-assigned this Jun 26, 2022
@codecov
Copy link
codecov bot commented Jun 26, 2022 •
edited
Loading

Codecov Report

Merging #76 (4ff32d8) into develop (53956da) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           develop       #76   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines           68        68           
  Branches        10        10           
=========================================
  Hits            68        68

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53956da...4ff32d8. Read the comment docs.

@wimpyprogrammer wimpyprogrammer merged commit db32e0c into develop Jun 26, 2022
@wimpyprogrammer wimpyprogrammer deleted the fix/node-16-testpack branch June 26, 2022 15:23
wimpyprogrammer added a commit that referenced this pull request Mar 25, 2025
@wimpyprogrammer
Require testpack to succeed for all supported Node versions
08a1f00 
Remove workaround added in #76 since it appears unneeded now.
@wimpyprogrammer wimpyprogrammer mentioned this pull request Mar 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wimpyprogrammer wimpyprogrammer

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wimpyprogrammer
0