8000 Require testpack to succeed for all supported Node versions · wimpyprogrammer/strings-to-regex@08a1f00 · GitHub
[go: up one dir, main page]
Skip to content

Commit 08a1f00

Browse files
wimpyprogrammerwimpyprogrammer
committed
Require testpack to succeed for all supported Node versions
Remove workaround added in #76 since it appears unneeded now.
1 parent 0b87ec2 commit 08a1f00

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

‎.github/workflows/tests.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,9 @@ jobs:
1919
fail-fast: false
2020
matrix:
2121
node-version: [16.x]
22-
require-successful-testpack: [true]
2322
include:
2423
- node-version: 18.x
25-
require-successful-testpack: false
2624
- node-version: lts/*
27-
require-successful-testpack: false
2825

2926
steps:
3027
- name: Checkout repository
@@ -45,8 +42,6 @@ jobs:
4542

4643
- run: npx testpack-cli --keep=@types/jest,ts-jest,typescript jest.config.js tsconfig.test.json src/e2e.spec.ts
4744
working-directory: ./packages/strings-to-regex
48-
# Workaround for #76
49-
continue-on-error: ${{ !matrix.require-successful-testpack }}
5045

5146
- name: Upload test coverage report to Codecov
5247
uses: codecov/codecov-action@v5.4.0

0 commit comments

Comments
 (0)
0