8000 Merge variants-json sub-branch into the main branch by mgorny · Pull Request #6 · wheelnext/pip · GitHub
[go: up one dir, main page]
Skip to content

Merge variants-json sub-branch into the main branch #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 25, 2025
Merged

Merge variants-json sub-branch into the main branch #6

merged 7 commits into from
Mar 25, 2025

Conversation

mgorny
Copy link
@mgorny mgorny commented Mar 25, 2025

Following the merge in variantlib.

mgorny and others added 7 commits March 2, 2025 15:51
@mgorny
Include variant hashes in tags only when needed
b353f55 
Add parameters to include variant hashes in supported tag list only
if any wheels found have variant hashes.  Fix supported tag list caching
to keep separate caches per parameters.  Start preparing for
`variants.json` support.

The design is aimed at supporting three scenarios:

1. Package version has no variant hashes -- we do not fetch
   `variants.json` and want tags without variants (much faster).

2. Package version has variant hashes -- we try to fetch
   `variants.json`, if we have it, then we want tags with these variants
   (faster).

3. Package version has variant hashes but no `variants.json` -- fallback
   to full list of tags with all possible variants (slow).

Currently only 1. and 3. are implemented.
@mgorny
Initial variants.json support
e9a68b3 
Add initial support for fetching and passing `variants.json`.  The file
is currently fetched (and cached), and passed to construct tags.
However, variant hashes are neither filtered nor sorted yet.

For the time being, I had to remove `@cache`, since it's incompatible
with dict parameters.
@mgorny
Pass whole variants.json to utils.variant and add caching
0af06e0
@mgorny
Wrap variants.json in a hashable class, and readd caching
71e9284
@mgorny
Enable variants_json API use in variantlib
45e389f
@mgorny
Update wheel filename regex for wheelnext/pep_xxx_wheel_variants#5
b0ee541
@DEKHTIARJonathan
Merge pull request #2 from mgorny/variants-json
7fbb325 
[WheelVariant] `variants.json` support prototype
DEKHTIARJonathan
DEKHTIARJonathan approved these changes Mar 25, 2025
View reviewed changes
Copy link
Member
@DEKHTIARJonathan DEKHTIARJonathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DEKHTIARJonathan DEKHTIARJonathan merged commit e4f70be into pep-xxx-wheel-variants Mar 25, 2025
3 of 24 checks passed
@DEKHTIARJonathan DEKHTIARJonathan deleted the pep-xxx-wheel-variants-variants-json branch March 25, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DEKHTIARJonathan DEKHTIARJonathan DEKHTIARJonathan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgorny @DEKHTIARJonathan
0