[WheelVariant] variants.json support prototype
#2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add parameters to include variant hashes in supported tag list only if any wheels found have variant hashes. Fix supported tag list caching to keep separate caches per parameters. Start preparing for `variants.json` support. The design is aimed at supporting three scenarios: 1. Package version has no variant hashes -- we do not fetch `variants.json` and want tags without variants (much faster). 2. Package version has variant hashes -- we try to fetch `variants.json`, if we have it, then we want tags with these variants (faster). 3. Package version has variant hashes but no `variants.json` -- fallback to full list of tags with all possible variants (slow). Currently only 1. and 3. are implemented.
Add initial support for fetching and passing `variants.json`. The file is currently fetched (and cached), and passed to construct tags. However, variant hashes are neither filtered nor sorted yet. For the time being, I had to remove `@cache`, since it's incompatible with dict parameters.
variants.json support prototypevariants.json support prototype
DEKHTIARJonathan
approved these changes
Mar 19, 2025
7fbb325
into
wheelnext:pep-xxx-wheel-variants-variants-json
3 of 25 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
2DA1
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite hacky, but I think that's the simplest way of injecting it. Basically:
need_variantsandvariants_jsonargument that are passed transitively to `get_supported():variants.json, we use the fast path to generate supported tags from specified variants.variants.jsonand none of the wheels include a variant hash, we don't include variants in supported tags, so we don't introduce slowdown for non-variant packages.variants.jsonand at least one includes a variant hash, we use the previous logic of generating all variants.variants.jsonfile first, so that we have it processed before processing the first wheel. Since the code apparently processes the index multiple times, I've added caching to avoid refetching it.variants.jsonis wrapped into thinVariantJsonclass that adds a__hash__()method, so that it can trivially work with@cache.Requires wheelnext/variantlib#2