8000 feat(index): Add sourcemap support (`options.sourceMap`) by aymasse · Pull Request #61 · webpack-contrib/script-loader · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Nov 5, 2019. It is now read-only.

feat(index): Add sourcemap support (options.sourceMap) #61

Merged
merged 8 commits into from
Mar 27, 2019
Merged

feat(index): Add sourcemap support (options.sourceMap) #61

merged 8 commits into from
Mar 27, 2019

Conversation

aymasse
Copy link
Contributor
@aymasse aymasse commented Jan 7, 2019

Hello,

This is the "continuation" of the work started by @driskell with the changes suggested by @michael-ciniawsky in PR #59 .
These changes add support for the sourceMap options in order to properly support source maps for newer versions of WebPack. Fixes #30

@jsf-clabot
Copy link
jsf-clabot commented Jan 7, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@aymasse aymasse mentioned this pull request Jan 7, 2019
Closed
2 tasks
@driskell
Copy link
driskell commented Jan 7, 2019

Thank you @aymasse! I had somewhat forgotten about this and have been too busy recently.

mistic
mistic reviewed Jan 31, 2019
View reviewed changes
Copy link
@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aymasse Just left a couple of suggestions. Otherwise LGTM

mistic
mistic approved these changes Jan 31, 2019
View reviewed changes
Copy link
@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mistic
Copy link
mistic commented Jan 31, 2019

@michael-ciniawsky do you think we can merge this?

alexander-akait
alexander-akait suggested changes Jan 31, 2019
View reviewed changes
Copy link
Member
@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, need update README

@mistic
Copy link
mistic commented Jan 31, 2019

Thanks for the help here @evilebottnawi! @aymasse Could you update the readme please?

@ChadHydro
Copy link
ChadHydro commented Mar 20, 2019 •
edited
Loading

Ping! @evilebottnawi

alexander-akait
alexander-akait suggested changes Mar 21, 2019
View reviewed changes
Copy link
Member
@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please fix note above

mistic
mistic reviewed Mar 21, 2019
View reviewed changes
@mistic @aymasse
Revert loader options retrieval
aa7b0a2 
Co-Authored-By: aymasse <aymasse@users.noreply.github.com>
alexander-akait
alexander-akait suggested changes Mar 22, 2019
View reviewed changes
@aymasse
Add loader-utils as a dependency
18ec823 
Package necessary to retrieve the loader's options
alexander-akait
alexander-akait suggested changes Mar 23, 2019
View reviewed changes
@alexander-akait alexander-akait merged commit 5ff1ee3 into webpack-contrib:master Mar 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ChadHydro ChadHydro ChadHydro left review comments

@mistic mistic mistic approved these changes

@alexander-akait alexander-akait alexander-akait requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aymasse @jsf-clabot @driskell @mistic @ChadHydro @alexander-akait
0